chrome/browser/android/browsing_data/browsing_data_bridge.h - Issue 2756173002: Move code about browsing data from PrefServiceBridge to BrowsingDataBridge.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/browsing_data/browsing_data_bridge.h

Issue 2756173002: Move code about browsing data from PrefServiceBridge to BrowsingDataBridge. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_BRIDGE_H_

	6 #define CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_BRIDGE_H_

	7

	8 #include <jni.h>

	9

	10 class BrowsingDataBridge {
	msramek 2017/03/23 16:02:04 style: Pure static classes are discouraged. If yo style: Pure static classes are discouraged. If you look at other bridges, it seems to be customary the customary approach for library-like bridge files is: bool RegisterBrowsingDataBridge(JNIEnv* env); dullweber 2017/03/24 09:19:43 I removed the class and renamed the function. Than Show quoted text On 2017/03/23 16:02:04, msramek wrote: > style: Pure static classes are discouraged. > > If you look at other bridges, it seems to be customary the customary approach > for library-like bridge files is: > > bool RegisterBrowsingDataBridge(JNIEnv* env); I removed the class and renamed the function. Thanks
	11 public:

	12 static bool Register(JNIEnv* env);

	13 };

	14

	15 #endif // CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_BRIDGE_H_

OLD	NEW