Move code about browsing data from PrefServiceBridge to BrowsingDataBridge.

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.content.SharedPreferences;
 import android.provider.Settings;
 import android.text.TextUtils;
 
 import org.chromium.base.ApplicationState;
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.ApplicationStatus.ApplicationStateListener;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.LocaleUtils;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.browser.accessibility.FontSizePrefs;
 import org.chromium.chrome.browser.browsing_data.BrowsingDataType;
 import org.chromium.chrome.browser.browsing_data.TimePeriod;
 import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.metrics.VariationsSession;
 import org.chromium.chrome.browser.notifications.NotificationPlatformBridge;
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
+import org.chromium.chrome.browser.preferences.privacy.BrowsingDataBridge;
 import org.chromium.chrome.browser.share.ShareHelper;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
 import org.chromium.chrome.browser.util.FeatureUtilities;
 import org.chromium.content.browser.ChildProcessLauncher;
 
 import java.lang.ref.WeakReference;
 
 /**
  * Tracks the foreground session state for the Chrome activities.
  */
@@ skipping 141 matching lines @@
 
     /**
      * Update the accept languages after changing Android locale setting. Doing so kills the
      * Activities but it doesn't kill the Application, so this should be called in
      * {@link #onStart} instead of {@link #initialize}.
      */
     private void updateAcceptLanguages() {
         PrefServiceBridge instance = PrefServiceBridge.getInstance();
         String localeString = LocaleUtils.getDefaultLocaleListString();
         if (hasLocaleChanged(localeString)) {
             instance.resetAcceptLanguages(localeString);

[msramek, 2017/03/23 16:02:04]

nit: This should now be called differently, since it's not the only thing in
this method that is an "instance".

[dullweber, 2017/03/24 09:19:43]

I removed the local variable because now it is only used once.

             // Clear cache so that accept-languages change can be applied immediately.
             // TODO(changwan): The underlying BrowsingDataRemover::Remove() is an asynchronous call.
             // So cache-clearing may not be effective if URL rendering can happen before
             // OnBrowsingDataRemoverDone() is called, in which case we may have to reload as well.
             // Check if it can happen.
-            instance.clearBrowsingData(
-                    null, new int[]{ BrowsingDataType.CACHE }, TimePeriod.ALL_TIME);
+            BrowsingDataBridge.getInstance().clearBrowsingData(
+                    null, new int[] {BrowsingDataType.CACHE}, TimePeriod.ALL_TIME);
         }
     }
 
     private boolean hasLocaleChanged(String newLocale) {
         String previousLocale = ContextUtils.getAppSharedPreferences().getString(PREF_LOCALE, null);
         if (!TextUtils.equals(previousLocale, newLocale)) {
             SharedPreferences prefs = ContextUtils.getAppSharedPreferences();
             SharedPreferences.Editor editor = prefs.edit();
             editor.putString(PREF_LOCALE, newLocale);
             editor.apply();
@@ skipping 27 matching lines @@
     }
 
     /**
      * @return The PowerBroadcastReceiver for the browser process.
      */
     @VisibleForTesting
     public PowerBroadcastReceiver getPowerBroadcastReceiverForTesting() {
         return mPowerBroadcastReceiver;
     }
 }