Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2756103003: Split NativeBasicDataImpl (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split NativeBasicDataImpl - into NativeBasicDataBuilderImpl and NativeBasicDataImpl R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a9811024cf488afe8ea9bf39ff62b9b4777d9809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -100 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 13 chunks +80 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 5 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 8 chunks +33 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 7 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-17 11:51:31 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-17 22:08:20 UTC) #3
Johnni Winther
3 years, 9 months ago (2017-03-27 09:59:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9811024cf488afe8ea9bf39ff62b9b4777d9809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698