Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

Issue 2756103002: DevTools: remove SDK.ResourceTreeFrame.fromXXX methods (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
index a3a5666e85f3240b914fed720adc2ebe23225a88..ecd5ceebdeeacd56aa1782ccb9764c621478cbf5 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
@@ -239,6 +239,8 @@ Bindings.CompilerScriptMapping = class {
// Report sources.
var missingSources = [];
+ var frame = SDK.ResourceTreeFrame.fromScript(script);
+ var frameId = frame ? frame.id : '';
for (var sourceURL of sourceMap.sourceURLs()) {
if (this._sourceMapForURL.get(sourceURL))
continue;
@@ -249,7 +251,7 @@ Bindings.CompilerScriptMapping = class {
var embeddedContent = sourceMap.embeddedContentByURL(sourceURL);
var embeddedContentLength = typeof embeddedContent === 'string' ? embeddedContent.length : null;
uiSourceCode = this._networkProject.addSourceMapFile(
- contentProvider, SDK.ResourceTreeFrame.fromScript(script), script.isContentScript(), embeddedContentLength);
+ contentProvider, frameId, script.isContentScript(), embeddedContentLength);
uiSourceCode[Bindings.CompilerScriptMapping._originSymbol] = script.sourceURL;
}
if (uiSourceCode) {
@@ -387,3 +389,4 @@ Bindings.CompilerScriptMapping = class {
};
Bindings.CompilerScriptMapping._originSymbol = Symbol('origin');
+Bindings.CompilerScriptMapping._frameSymbol = Symbol('Bindings.CompilerScriptMapping._frameSymbol');
dgozman 2017/03/17 19:00:21 Unused.
lushnikov 2017/03/17 21:21:47 Done.

Powered by Google App Engine
This is Rietveld 408576698