DevTools: remove SDK.ResourceTreeFrame.fromXXX methods

third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 203 matching lines @@
     return null;
   }
 
   /**
    * @param {!SDK.CSSStyleSheetHeader} header
    */
   _detachSourceMap(header) {
     if (!header.sourceMapURL || !this._sourceMapURLToHeaders.hasValue(header.sourceMapURL, header))
       return;
     this._sourceMapURLToHeaders.remove(header.sourceMapURL, header);
+    var sourceMap = this._sourceMapByURL.get(header.sourceMapURL);
     if (!this._sourceMapURLToHeaders.has(header.sourceMapURL))
       this._sourceMapByURL.delete(header.sourceMapURL);
-    this.dispatchEventToListeners(SDK.CSSModel.Events.SourceMapDetached, header);
+    this.dispatchEventToListeners(SDK.CSSModel.Events.SourceMapDetached, {header: header, sourceMap: sourceMap});

[dgozman, 2017/03/17 19:00:21]

This removes source map sources whenever first header goes away. For example,
shadow dom stuff breaks.

[lushnikov, 2017/03/17 21:21:47]

I started writing tests and it turned out that we already are not doing proper
job in resolving sourcemap urls. I'll address the issue separately; let's land
the frameId usage for now

   }
 
   /**
    * @return {!SDK.DOMModel}
    */
   domModel() {
     return this._domModel;
   }
 
   /**
@@ skipping 929 matching lines @@
 SDK.CSSModel.InlineStyleResult = class {
   /**
    * @param {?SDK.CSSStyleDeclaration} inlineStyle
    * @param {?SDK.CSSStyleDeclaration} attributesStyle
    */
   constructor(inlineStyle, attributesStyle) {
     this.inlineStyle = inlineStyle;
     this.attributesStyle = attributesStyle;
   }
 };