DevTools: remove SDK.ResourceTreeFrame.fromXXX methods

third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 46 matching lines @@
   /**
    * @param {!Common.Event} event
    */
   _sourceMapAttached(event) {
     var header = /** @type {!SDK.CSSStyleSheetHeader} */ (event.data);
     var sourceMap = this._cssModel.sourceMapForHeader(header);
     for (var sassURL of sourceMap.sourceURLs()) {
       var contentProvider = sourceMap.sourceContentProvider(sassURL, Common.resourceTypes.SourceMapStyleSheet);
       var embeddedContent = sourceMap.embeddedContentByURL(sassURL);
       var embeddedContentLength = typeof embeddedContent === 'string' ? embeddedContent.length : null;
-      this._networkProject.addSourceMapFile(
-          contentProvider, SDK.ResourceTreeFrame.fromStyleSheet(header), false, embeddedContentLength);

[dgozman, 2017/03/17 19:00:21]

I think you can cleanup SDK.ResourceTreeFrame.fromXXX methods now.

[lushnikov, 2017/03/17 21:21:47]

YAY! Done.

+      this._networkProject.addSourceMapFile(contentProvider, header.frameId, false, embeddedContentLength);
     }
     Bindings.cssWorkspaceBinding.updateLocations(header);
     this._sourceMapAttachedForTest(sourceMap);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _sourceMapDetached(event) {
-    var header = /** @type {!SDK.CSSStyleSheetHeader} */ (event.data);
+    var header = /** @type {!SDK.CSSStyleSheetHeader} */ (event.data.header);
+    var sourceMap = /** @type {!SDK.SourceMap} */ (event.data.sourceMap);
     Bindings.cssWorkspaceBinding.updateLocations(header);
+    for (var sassURL of sourceMap.sourceURLs())
+      this._networkProject.removeSourceMapFile(sassURL, header.frameId, false);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _sourceMapChanged(event) {
     var sourceMap = /** @type {!SDK.SourceMap} */ (event.data.sourceMap);
     var newSources = /** @type {!Map<string, string>} */ (event.data.newSources);
     var headers = this._cssModel.headersForSourceMap(sourceMap);
     var handledUISourceCodes = new Set();
@@ skipping 30 matching lines @@
       return null;
     var uiSourceCode = Bindings.NetworkProject.uiSourceCodeForStyleURL(this._workspace, entry.sourceURL, header);
     if (!uiSourceCode)
       return null;
     return uiSourceCode.uiLocation(entry.sourceLineNumber || 0, entry.sourceColumnNumber);
   }
 
   dispose() {
     Common.EventTarget.removeEventListeners(this._eventListeners);
   }
-};
+};