content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java - Issue 2756053002: Abstracting parameters passed to child processes on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

Issue 2756053002: Abstracting parameters passed to child processes on Android. (Closed)

Patch Set: Abstracting parameters passed to child processes on Android. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

index 7467065d5983eabbeed4b7ad272e5336da3162e2..063b876645868ecf4f5ba248a1e3cbdd3b155910 100644

--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

@@ -335,7 +335,8 @@ public class ChildProcessServiceImpl {

synchronized (mMainThread) {

// mLinkerParams is never used if Linker.isUsed() returns false.

// See onCreate().

- mLinkerParams = new ChromiumLinkerParams(intent);

+ mLinkerParams = (ChromiumLinkerParams) intent.getParcelableExtra(

+ ChildProcessConstants.EXTRA_LINKER_PARAMS);

mLibraryProcessType = ChildProcessCreationParams.getLibraryProcessType(intent);

mMainThread.notifyAll();

}