Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: pkg/front_end/lib/src/fasta/source/source_loader.dart

Issue 2755983002: Implement override checks for methods. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/source_loader.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_loader.dart b/pkg/front_end/lib/src/fasta/source/source_loader.dart
index 3c67c0cdc7668f6d4e23f360ac07fe28dd38faee..8e56b059e0f780543c370e4c642d10e4b88c3cb8 100644
--- a/pkg/front_end/lib/src/fasta/source/source_loader.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_loader.dart
@@ -10,29 +10,29 @@ import 'dart:io' show FileSystemException;
import 'dart:typed_data' show Uint8List;
-import '../scanner/io.dart' show readBytesFromFile;
-
-import '../scanner.dart' show ErrorToken, ScannerResult, Token, scan;
-
-import '../parser/class_member_parser.dart' show ClassMemberParser;
-
import 'package:kernel/ast.dart' show Program;
import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
import 'package:kernel/core_types.dart' show CoreTypes;
-import '../errors.dart' show inputError;
+import '../builder/builder.dart' show Builder, ClassBuilder, LibraryBuilder;
-import '../messages.dart' show warning;
+import '../compiler_context.dart' show CompilerContext;
+
+import '../errors.dart' show inputError;
import '../export.dart' show Export;
-import '../builder/builder.dart' show Builder, ClassBuilder, LibraryBuilder;
+import '../loader.dart' show Loader;
-import 'outline_builder.dart' show OutlineBuilder;
+import '../messages.dart' show warning;
-import '../loader.dart' show Loader;
+import '../parser/class_member_parser.dart' show ClassMemberParser;
+
+import '../scanner.dart' show ErrorToken, ScannerResult, Token, scan;
+
+import '../scanner/io.dart' show readBytesFromFile;
import '../target_implementation.dart' show TargetImplementation;
@@ -40,9 +40,11 @@ import 'diet_listener.dart' show DietListener;
import 'diet_parser.dart' show DietParser;
-import 'source_library_builder.dart' show SourceLibraryBuilder;
+import 'outline_builder.dart' show OutlineBuilder;
-import '../compiler_context.dart' show CompilerContext;
+import 'source_class_builder.dart' show SourceClassBuilder;
+
+import 'source_library_builder.dart' show SourceLibraryBuilder;
class SourceLoader<L> extends Loader<L> {
final Map<Uri, List<int>> sourceBytes = <Uri, List<int>>{};
@@ -360,5 +362,13 @@ class SourceLoader<L> extends Loader<L> {
ticker.logMs("Computed core types");
}
+ void checkOverrides(List<SourceClassBuilder> sourceClasses) {
+ assert(hierarchy != null);
+ for (SourceClassBuilder builder in sourceClasses) {
+ builder.checkOverrides(hierarchy);
+ }
+ ticker.logMs("Checked overrides");
+ }
+
List<Uri> getDependencies() => sourceBytes.keys.toList();
}

Powered by Google App Engine
This is Rietveld 408576698