Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: pkg/front_end/lib/src/fasta/builder/library_builder.dart

Issue 2755983002: Implement override checks for methods. (Closed)
Patch Set: Add TODO and merged with master. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/class_builder.dart ('k') | pkg/front_end/lib/src/fasta/colors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/builder/library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/library_builder.dart b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
index 9e1325bb244511d73789ff70ad52467041b6f35f..f4662c1f0bab2d9c98255d3da369286d4b6caa51 100644
--- a/pkg/front_end/lib/src/fasta/builder/library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
@@ -12,6 +12,8 @@ import '../export.dart' show Export;
import '../loader.dart' show Loader;
+import '../messages.dart' show nit, warning;
+
import '../util/relativize.dart' show relativizeUri;
import 'builder.dart' show Builder, ClassBuilder, TypeBuilder;
@@ -60,6 +62,22 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
compileTimeErrors.add(new InputError(fileUri, charOffset, message));
}
+ void addWarning(int charOffset, Object message,
+ {Uri fileUri, bool silent: false}) {
+ fileUri ??= this.fileUri;
+ if (!silent) {
+ warning(fileUri, charOffset, message);
+ }
+ }
+
+ void addNit(int charOffset, Object message,
+ {Uri fileUri, bool silent: false}) {
+ fileUri ??= this.fileUri;
+ if (!silent) {
+ nit(fileUri, charOffset, message);
+ }
+ }
+
bool addToExportScope(String name, Builder member);
void addToScope(String name, Builder member);
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/class_builder.dart ('k') | pkg/front_end/lib/src/fasta/colors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698