Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/library_builder.dart

Issue 2755983002: Implement override checks for methods. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.library_builder; 5 library fasta.library_builder;
6 6
7 import '../combinator.dart' show Combinator; 7 import '../combinator.dart' show Combinator;
8 8
9 import '../errors.dart' show InputError, internalError, printUnexpected; 9 import '../errors.dart' show InputError, internalError, printUnexpected;
10 10
11 import '../export.dart' show Export; 11 import '../export.dart' show Export;
12 12
13 import '../loader.dart' show Loader; 13 import '../loader.dart' show Loader;
14 14
15 import '../messages.dart' show nit, warning;
16
15 import '../util/relativize.dart' show relativizeUri; 17 import '../util/relativize.dart' show relativizeUri;
16 18
17 import 'builder.dart' show Builder, ClassBuilder, TypeBuilder; 19 import 'builder.dart' show Builder, ClassBuilder, TypeBuilder;
18 20
19 import 'scope.dart' show Scope; 21 import 'scope.dart' show Scope;
20 22
21 abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder { 23 abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
22 final List<Export> exporters = <Export>[]; 24 final List<Export> exporters = <Export>[];
23 25
24 final List<InputError> compileTimeErrors = <InputError>[]; 26 final List<InputError> compileTimeErrors = <InputError>[];
(...skipping 28 matching lines...) Expand all
53 55
54 void addCompileTimeError(int charOffset, Object message, 56 void addCompileTimeError(int charOffset, Object message,
55 {Uri fileUri, bool silent: false}) { 57 {Uri fileUri, bool silent: false}) {
56 fileUri ??= this.fileUri; 58 fileUri ??= this.fileUri;
57 if (!silent) { 59 if (!silent) {
58 printUnexpected(fileUri, charOffset, message); 60 printUnexpected(fileUri, charOffset, message);
59 } 61 }
60 compileTimeErrors.add(new InputError(fileUri, charOffset, message)); 62 compileTimeErrors.add(new InputError(fileUri, charOffset, message));
61 } 63 }
62 64
65 void addWarning(int charOffset, Object message,
66 {Uri fileUri, bool silent: false}) {
67 fileUri ??= this.fileUri;
68 if (!silent) {
69 warning(fileUri, charOffset, message);
70 }
71 }
72
73 void addNit(int charOffset, Object message,
74 {Uri fileUri, bool silent: false}) {
75 fileUri ??= this.fileUri;
76 if (!silent) {
77 nit(fileUri, charOffset, message);
78 }
79 }
80
63 bool addToExportScope(String name, Builder member); 81 bool addToExportScope(String name, Builder member);
64 82
65 void addToScope(String name, Builder member); 83 void addToScope(String name, Builder member);
66 84
67 Builder buildAmbiguousBuilder( 85 Builder buildAmbiguousBuilder(
68 String name, Builder builder, Builder other, int charOffset); 86 String name, Builder builder, Builder other, int charOffset);
69 87
70 int finishStaticInvocations() => 0; 88 int finishStaticInvocations() => 0;
71 89
72 int finishNativeMethods() => 0; 90 int finishNativeMethods() => 0;
(...skipping 21 matching lines...) Expand all
94 } else if (constructor.isFactory) { 112 } else if (constructor.isFactory) {
95 return constructor; 113 return constructor;
96 } 114 }
97 } 115 }
98 throw internalError("Internal error: No constructor named" 116 throw internalError("Internal error: No constructor named"
99 " '$className::$constructorName' in '$uri'."); 117 " '$className::$constructorName' in '$uri'.");
100 } 118 }
101 119
102 int finishTypeVariables(ClassBuilder object) => 0; 120 int finishTypeVariables(ClassBuilder object) => 0;
103 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698