Implement override checks for methods.

Implement override checks for methods.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/1a47ef1a7712b3618ec0f112d91bb5af532daa21

[ahe, 2017-03-16 17:32:37]

ahe@google.com changed reviewers:
+ paulberry@google.com

[ahe, 2017-03-16 17:32:37]

This isn't ready for review yet, I just wanted to show you one place I need a
subtype check (and strong mode top-level inference).

https://codereview.chromium.org/2755983002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart (right):

https://codereview.chromium.org/2755983002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:201: FunctionNode
interfaceFunction = interfaceMember.function;
These two function nodes have lists of parameters that needs subtype checks, and
potentially strong mode inference.

[ahe, 2017-03-17 11:22:40]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-03-17 11:24:03]

Patchset #2 (id:40001) has been deleted

[ahe, 2017-03-17 11:28:15]

Patchset #2 (id:60001) has been deleted

[ahe, 2017-03-17 11:28:44]

ahe@google.com changed reviewers:
+ johnniwinther@google.com
- paulberry@google.com

[ahe, 2017-03-17 11:28:45]

This is now ready for review. Johnni, could you take a look?

[Johnni Winther, 2017-03-17 11:46:48]

lgtm

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart (right):

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:192: }
TODO: check getters/setters/operators

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:231: "positional
arguments than those of overridden method "
'positional' -> 'required'

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:262: "of override
method '${interfaceMember.enclosingClass.name}::"
override -> overridden

[ahe, 2017-03-17 13:24:37]

Thank you, Johnni.

I made a minor tweak to the code: it turns out that declaredMember may not be a
member of the current class, and for now, I've skipped those (so the warnings
from typed_data go away).

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart (right):

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:192: }
On 2017/03/17 11:46:48, Johnni Winther wrote:
> TODO: check getters/setters/operators

Done.

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:231: "positional
arguments than those of overridden method "
On 2017/03/17 11:46:47, Johnni Winther wrote:
> 'positional' -> 'required'

That was intentional. I consider this case similar to the one above. Only
difference is who has more parameters.

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:262: "of override
method '${interfaceMember.enclosingClass.name}::"
On 2017/03/17 11:46:47, Johnni Winther wrote:
> override -> overridden

Done.

[ahe, 2017-03-17 13:31:15]

Description was changed from

==========
Implement override checks for methods.
==========

to

==========
Implement override checks for methods.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1a47ef1a7712b3618ec0f112d91bb5af532daa21
==========

[ahe, 2017-03-17 13:31:16]

Committed patchset #4 (id:120001) manually as
1a47ef1a7712b3618ec0f112d91bb5af532daa21 (presubmit successful).

[Johnni Winther, 2017-03-17 13:36:19]

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart (right):

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:231: "positional
arguments than those of overridden method "
On 2017/03/17 13:24:37, ahe wrote:
> On 2017/03/17 11:46:47, Johnni Winther wrote:
> > 'positional' -> 'required'
> 
> That was intentional. I consider this case similar to the one above. Only
> difference is who has more parameters.

Yes, but from the users perspective it doesn't make sense; they are allowed to
add more positional (optional) parameters but not more required.

[ahe, 2017-03-17 14:02:52]

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart (right):

https://codereview.chromium.org/2755983002/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart:231: "positional
arguments than those of overridden method "
On 2017/03/17 13:36:19, Johnni Winther wrote:
> On 2017/03/17 13:24:37, ahe wrote:
> > On 2017/03/17 11:46:47, Johnni Winther wrote:
> > > 'positional' -> 'required'
> > 
> > That was intentional. I consider this case similar to the one above. Only
> > difference is who has more parameters.
> 
> Yes, but from the users perspective it doesn't make sense; they are allowed to
> add more positional (optional) parameters but not more required.

Good point. I'll send an update.