Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: content/shell/browser/shell_devtools_frontend.h

Issue 2755973003: DevTools: android shouldn't depend on devtools frontend (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/BUILD.gn ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "content/public/browser/devtools_agent_host.h" 15 #include "content/public/browser/devtools_agent_host.h"
16 #include "content/public/browser/devtools_frontend_host.h"
17 #include "content/public/browser/web_contents_observer.h" 16 #include "content/public/browser/web_contents_observer.h"
18 #include "net/url_request/url_fetcher_delegate.h" 17 #include "net/url_request/url_fetcher_delegate.h"
19 18
19 #if !defined(OS_ANDROID)
20 #include "content/public/browser/devtools_frontend_host.h"
21 #endif
22
20 namespace base { 23 namespace base {
21 class Value; 24 class Value;
22 } 25 }
23 26
24 namespace content { 27 namespace content {
25 28
26 class RenderViewHost; 29 class RenderViewHost;
27 class Shell; 30 class Shell;
28 class WebContents; 31 class WebContents;
29 32
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 void OnURLFetchComplete(const net::URLFetcher* source) override; 71 void OnURLFetchComplete(const net::URLFetcher* source) override;
69 72
70 void SendMessageAck(int request_id, 73 void SendMessageAck(int request_id,
71 const base::Value* arg1); 74 const base::Value* arg1);
72 75
73 Shell* frontend_shell_; 76 Shell* frontend_shell_;
74 WebContents* inspected_contents_; 77 WebContents* inspected_contents_;
75 scoped_refptr<DevToolsAgentHost> agent_host_; 78 scoped_refptr<DevToolsAgentHost> agent_host_;
76 int inspect_element_at_x_; 79 int inspect_element_at_x_;
77 int inspect_element_at_y_; 80 int inspect_element_at_y_;
81 #if !defined(OS_ANDROID)
78 std::unique_ptr<DevToolsFrontendHost> frontend_host_; 82 std::unique_ptr<DevToolsFrontendHost> frontend_host_;
83 #endif
79 using PendingRequestsMap = std::map<const net::URLFetcher*, int>; 84 using PendingRequestsMap = std::map<const net::URLFetcher*, int>;
80 PendingRequestsMap pending_requests_; 85 PendingRequestsMap pending_requests_;
81 base::DictionaryValue preferences_; 86 base::DictionaryValue preferences_;
82 base::WeakPtrFactory<ShellDevToolsFrontend> weak_factory_; 87 base::WeakPtrFactory<ShellDevToolsFrontend> weak_factory_;
83 88
84 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsFrontend); 89 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsFrontend);
85 }; 90 };
86 91
87 } // namespace content 92 } // namespace content
88 93
89 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 94 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
OLDNEW
« no previous file with comments | « content/shell/BUILD.gn ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698