DevTools: android shouldn't depend on devtools frontend

content/browser/devtools/devtools_frontend_host_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_frontend_host_impl.h"
 
 #include <stddef.h>
 
 #include "content/browser/bad_message.h"
-#include "content/browser/devtools/grit/devtools_resources_map.h"
 #include "content/common/devtools_messages.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 
+#if !defined(OS_ANDROID)
+#include "content/browser/devtools/grit/devtools_resources_map.h"  // nogncheck

[chenwilliam, 2017/03/16 23:08:13]

gn complains when cross-compiling (Linux compiling for Android) if I don't
include this.

[dgozman, 2017/03/16 23:09:39]

That means we should not compile this file on android as well.

+#endif
+
 namespace content {
 
 namespace {
 const char kCompatibilityScript[] = "devtools_compatibility.js";
 const char kCompatibilityScriptSourceURL[] =
     "\n//# "
     "sourceURL=chrome-devtools://devtools/bundled/devtools_compatibility.js";
 }
 
 // static
 DevToolsFrontendHost* DevToolsFrontendHost::Create(
     RenderFrameHost* frontend_main_frame,
     const HandleMessageCallback& handle_message_callback) {
   return new DevToolsFrontendHostImpl(frontend_main_frame,
                                       handle_message_callback);
 }
 
 // static
+#if !defined(OS_ANDROID)
 base::StringPiece DevToolsFrontendHost::GetFrontendResource(
     const std::string& path) {
   for (size_t i = 0; i < kDevtoolsResourcesSize; ++i) {
     if (path == kDevtoolsResources[i].name) {
       return GetContentClient()->GetDataResource(
           kDevtoolsResources[i].value, ui::SCALE_FACTOR_NONE);
     }
   }
   return std::string();
 }
+#endif
+
+// static
+#if defined(OS_ANDROID)
+base::StringPiece DevToolsFrontendHost::GetFrontendResource(
+    const std::string& path) {
+  return std::string();
+}
+#endif
 
 DevToolsFrontendHostImpl::DevToolsFrontendHostImpl(
     RenderFrameHost* frontend_main_frame,
     const HandleMessageCallback& handle_message_callback)
     : WebContentsObserver(
           WebContents::FromRenderFrameHost(frontend_main_frame)),
       handle_message_callback_(handle_message_callback) {
   frontend_main_frame->Send(new DevToolsMsg_SetupDevToolsClient(
       frontend_main_frame->GetRoutingID(),
       DevToolsFrontendHost::GetFrontendResource(kCompatibilityScript)
@@ skipping 22 matching lines @@
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void DevToolsFrontendHostImpl::OnDispatchOnEmbedder(
     const std::string& message) {
   handle_message_callback_.Run(message);
 }
 
 }  // namespace content