[type profile] Collect return types.

src/compiler/bytecode-graph-builder.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_
 #define V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_
 
 #include "src/compiler/bytecode-analysis.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/liveness-analyzer.h"
@@ skipping 66 matching lines @@
   Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3) {
     Node* buffer[] = {n1, n2, n3};
     return MakeNode(op, arraysize(buffer), buffer, false);
   }
 
   Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4) {
     Node* buffer[] = {n1, n2, n3, n4};
     return MakeNode(op, arraysize(buffer), buffer, false);
   }
 
+  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,

[ahaas, 2017/03/20 09:34:43]

You could be super fancy and do this with variadic templates. Instead of
introducing a new NewNode function, you could replace all NewNode functions by
  template<typename... Nodes>
  Node* NewNode(const Operator* op, Nodes... n) {
    Node* buffer[] = {n...};
    return MakeNode(op, arraysize(buffer), buffer, false);
  }

[ahaas, 2017/03/20 09:53:36]

better use

  template<typename... Nodes>
  Node* NewNode(const Operator* op, Node* n0, Nodes... n) {
    Node* buffer[] = {n0, n...};
    return MakeNode(op, arraysize(buffer), buffer, false);
  }

because otherwise there could be a signature overlap with 
  Node* NewNode(const Operator* op, bool incomplete = false)

[Franzi, 2017/03/20 15:38:39]

No chance to be super fancy :( Don't need NewNode() with 5 nodes anymore. 

+                Node* n5) {
+    Node* buffer[] = {n1, n2, n3, n4, n5};
+    return MakeNode(op, arraysize(buffer), buffer, false);
+  }
+
   // Helpers to create new control nodes.
   Node* NewIfTrue() { return NewNode(common()->IfTrue()); }
   Node* NewIfFalse() { return NewNode(common()->IfFalse()); }
   Node* NewMerge() { return NewNode(common()->Merge(1), true); }
   Node* NewLoop() { return NewNode(common()->Loop(1), true); }
   Node* NewBranch(Node* condition, BranchHint hint = BranchHint::kNone) {
     return NewNode(common()->Branch(hint), condition);
   }
 
   // Creates a new Phi node having {count} input values.
@@ skipping 252 matching lines @@
   static int const kBinaryOperationSmiHintIndex = 2;
 
   DISALLOW_COPY_AND_ASSIGN(BytecodeGraphBuilder);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_