[Devtools] Add stacktrace to protocol for scriptParsed event

src/inspector/v8-debugger-agent-impl.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-debugger-agent-impl.h"
 
 #include <algorithm>
 
 #include "src/debug/debug-interface.h"
 #include "src/inspector/injected-script.h"
@@ skipping 1117 matching lines @@
   // make any change that change isFunctionBlackboxed output - adding parsed
   // script is changing.
   scriptRef->resetBlackboxedStateCache();
 
   Maybe<String16> sourceMapURLParam = scriptRef->sourceMappingURL();
   Maybe<protocol::DictionaryValue> executionContextAuxDataParam(
       std::move(executionContextAuxData));
   const bool* isLiveEditParam = isLiveEdit ? &isLiveEdit : nullptr;
   const bool* hasSourceURLParam = hasSourceURL ? &hasSourceURL : nullptr;
   const bool* isModuleParam = isModule ? &isModule : nullptr;
-  if (success)
+  if (success) {
+    std::unique_ptr<V8StackTraceImpl> stack =
+        V8StackTraceImpl::capture(m_inspector->debugger(), contextGroupId,

[dgozman, 2017/03/16 18:39:03]

Do we need the whole stack? Maybe just a top frame? I'm worried this could be
slow. Let's measure the performance impact.

[allada, 2017/03/16 21:02:12]

Per our offline discussion, capturing 1 frame was apx 5% slower capturing full
stack trace was 10-15% slower

+                                  V8StackTraceImpl::maxCallStackSizeToCapture);
+    std::unique_ptr<protocol::Runtime::StackTrace> stackTrace =
+        stack && !stack->isEmpty() ? stack->buildInspectorObjectImpl()
+                                   : nullptr;
     m_frontend.scriptParsed(
         scriptId, scriptURL, scriptRef->startLine(), scriptRef->startColumn(),
         scriptRef->endLine(), scriptRef->endColumn(), contextId,
         scriptRef->hash(), std::move(executionContextAuxDataParam),
         isLiveEditParam, std::move(sourceMapURLParam), hasSourceURLParam,
-        isModuleParam, scriptRef->source().length());
-  else
+        isModuleParam, scriptRef->source().length(), std::move(stackTrace));

[kozy, 2017/03/16 18:35:12]

let's do the same for scriptFailedToParse.

[allada, 2017/03/16 21:02:12]

Done.

+  } else {
     m_frontend.scriptFailedToParse(
         scriptId, scriptURL, scriptRef->startLine(), scriptRef->startColumn(),
         scriptRef->endLine(), scriptRef->endColumn(), contextId,
         scriptRef->hash(), std::move(executionContextAuxDataParam),
         std::move(sourceMapURLParam), hasSourceURLParam, isModuleParam,
         scriptRef->source().length());

[dgozman, 2017/03/16 18:39:04]

It makes sense to send it for syntax errors as well.

[allada, 2017/03/16 21:02:12]

Done.

+  }
 
   if (scriptURL.isEmpty() || !success) return;
 
   protocol::DictionaryValue* breakpointsCookie =
       m_state->getObject(DebuggerAgentState::javaScriptBreakpoints);
   if (!breakpointsCookie) return;
 
   for (size_t i = 0; i < breakpointsCookie->size(); ++i) {
     auto cookie = breakpointsCookie->at(i);
     protocol::DictionaryValue* breakpointObject =
@@ skipping 181 matching lines @@
 void V8DebuggerAgentImpl::reset() {
   if (!enabled()) return;
   m_scheduledDebuggerStep = NoStep;
   m_blackboxedPositions.clear();
   resetBlackboxedStateCache();
   m_scripts.clear();
   m_breakpointIdToDebuggerBreakpointIds.clear();
 }
 
 }  // namespace v8_inspector