Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: ios/web/navigation/crw_session_controller_unittest.mm

Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/crw_session_controller_unittest.mm
diff --git a/ios/web/navigation/crw_session_controller_unittest.mm b/ios/web/navigation/crw_session_controller_unittest.mm
index 087aa4b0cb56e4dd90b07002b702cbaf8c292a1d..a5d7096920e94d09e3bd2af3ec768cc72addc776 100644
--- a/ios/web/navigation/crw_session_controller_unittest.mm
+++ b/ios/web/navigation/crw_session_controller_unittest.mm
@@ -45,9 +45,8 @@ @implementation CRWSessionController (Testing)
class CRWSessionControllerTest : public PlatformTest {
protected:
void SetUp() override {
- session_controller_.reset([[CRWSessionController alloc]
- initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ session_controller_.reset(
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
}
web::Referrer MakeReferrer(const std::string& url) {
@@ -60,7 +59,6 @@ void SetUp() override {
};
TEST_F(CRWSessionControllerTest, Init) {
- EXPECT_FALSE([session_controller_ isOpenedByDOM]);
EXPECT_TRUE([session_controller_ items].empty());
EXPECT_FALSE([session_controller_ currentItem]);
}
@@ -489,8 +487,7 @@ void SetUp() override {
// Create source session controller with 1 committed item.
base::scoped_nsobject<CRWSessionController> other_session_controller(
- [[CRWSessionController alloc] initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
[other_session_controller
addPendingItem:GURL("http://www.url.com/0")
referrer:web::Referrer()
@@ -539,8 +536,7 @@ void SetUp() override {
// Create empty source session controller.
base::scoped_nsobject<CRWSessionController> other_session_controller(
- [[CRWSessionController alloc] initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
// Insert and verify the state of target session controller.
EXPECT_TRUE([session_controller_ canPruneAllButLastCommittedItem]);
@@ -564,8 +560,7 @@ void SetUp() override {
// Create source session controller with 1 committed item.
base::scoped_nsobject<CRWSessionController> other_session_controller(
- [[CRWSessionController alloc] initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
[other_session_controller
addPendingItem:GURL("http://www.url.com/0")
referrer:web::Referrer()
@@ -609,8 +604,7 @@ void SetUp() override {
// Create source session controller with 1 committed item.
base::scoped_nsobject<CRWSessionController> other_session_controller(
- [[CRWSessionController alloc] initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
[other_session_controller
addPendingItem:GURL("http://www.url.com/0")
referrer:web::Referrer()
@@ -660,8 +654,7 @@ void SetUp() override {
// Create source session controller with 1 committed item.
base::scoped_nsobject<CRWSessionController> other_session_controller(
- [[CRWSessionController alloc] initWithBrowserState:&browser_state_
- openedByDOM:NO]);
+ [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
[other_session_controller
addPendingItem:GURL("http://www.url.com/0")
referrer:web::Referrer()
« no previous file with comments | « ios/web/navigation/crw_session_controller+private_constructors.h ('k') | ios/web/navigation/crw_session_storage_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698