ios/web/public/crw_session_storage.mm - Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/crw_session_storage.mm

Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface. (Closed)

Patch Set: test fix & removed include Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/browser_view_controller.mm ('K') | « ios/web/public/crw_session_storage.h ('k') | ios/web/public/test/fakes/test_web_state.h » ('j') | ios/web/public/web_state/web_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/public/crw_session_storage.mm

diff --git a/ios/web/public/crw_session_storage.mm b/ios/web/public/crw_session_storage.mm

index a2c3d25602405e28da6bf5474dae3e0472004a99..bd92956c640dbe0b53f216fb8d8546361f1ab215 100644

--- a/ios/web/public/crw_session_storage.mm

+++ b/ios/web/public/crw_session_storage.mm

@@ -16,7 +16,7 @@

NSString* const kCertificatePolicyManagerKey = @"certificatePolicyManager";

NSString* const kCurrentNavigationIndexKey = @"currentNavigationIndex";

NSString* const kItemStoragesKey = @"entries";

-NSString* const kOpenedByDOMKey = @"openedByDOM";

+NSString* const kHasOpenerKey = @"openedByDOM";

Eugene But (OOO till 7-30) 2017/03/18 00:33:30 Optional nit: do you want to deprecate this key in

kkhorimoto 2017/03/20 22:39:20 Acknowledged.

NSString* const kPreviousNavigationIndexKey = @"previousNavigationIndex";

}

@@ -29,7 +29,7 @@ @interface CRWSessionStorage () {

@implementation CRWSessionStorage

-@synthesize openedByDOM = _openedByDOM;

+@synthesize hasOpener = _hasOpener;

@synthesize currentNavigationIndex = _currentNavigationIndex;

@synthesize previousNavigationIndex = _previousNavigationIndex;

@synthesize itemStorages = _itemStorages;

@@ -51,7 +51,7 @@ - (void)setSerializableUserData:

- (instancetype)initWithCoder:(nonnull NSCoder*)decoder {

self = [super init];

if (self) {

- _openedByDOM = [decoder decodeBoolForKey:kOpenedByDOMKey];

+ _hasOpener = [decoder decodeBoolForKey:kHasOpenerKey];

_currentNavigationIndex =

[decoder decodeIntForKey:kCurrentNavigationIndexKey];

_previousNavigationIndex =

@@ -74,7 +74,7 @@ - (instancetype)initWithCoder:(nonnull NSCoder*)decoder {

}

- (void)encodeWithCoder:(NSCoder*)coder {

- [coder encodeBool:self.openedByDOM forKey:kOpenedByDOMKey];

+ [coder encodeBool:self.hasOpener forKey:kHasOpenerKey];

[coder encodeInt:self.currentNavigationIndex

forKey:kCurrentNavigationIndexKey];

[coder encodeInt:self.previousNavigationIndex