Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2755823002: Moved |openedByDOM| to WebState's CreateParams and public interface. (Closed)
Patch Set: test fix & removed include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index d1fac84f950b3cc010faddaeee64327f998a0f59..017c8c930faddaa2ef68a0150d3ddc50d2730448 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -481,9 +481,9 @@ - (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
opener:(Tab*)opener
openedByDOM:(BOOL)openedByDOM
model:(TabModel*)parentModel {
- std::unique_ptr<web::WebStateImpl> webState(
- new web::WebStateImpl(browserState));
- webState->GetNavigationManagerImpl().InitializeSession(openedByDOM);
+ web::WebState::CreateParams params(browserState);
+ params.created_with_opener = openedByDOM;
+ std::unique_ptr<web::WebState> webState = web::WebState::Create(params);
if ([opener navigationManager]) {
web::SerializableUserDataManager* userDataManager =
web::SerializableUserDataManager::FromWebState(webState.get());
@@ -1508,7 +1508,7 @@ - (void)reloadForDesktopUserAgent {
// |originalUrl| will be empty if a page was open by DOM.
GURL reloadURL(lastUserItem->GetOriginalRequestURL());
if (reloadURL.is_empty()) {
- DCHECK(sessionController.openedByDOM);
+ DCHECK(self.webState && self.webState->HasOpener());
reloadURL = lastUserItem->GetVirtualURL();
}

Powered by Google App Engine
This is Rietveld 408576698