Moved |openedByDOM| to WebState's CreateParams and public interface.

ios/web/public/web_state/web_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 39 matching lines @@
 class WebStateWeakPtrFactory;
 
 // Core interface for interaction with the web.
 class WebState : public base::SupportsUserData {
  public:
   // Parameters for the Create() method.
   struct CreateParams {
     explicit CreateParams(web::BrowserState* browser_state);
     ~CreateParams();
 
+    // The corresponding BrowserState for the new WebState.
     web::BrowserState* browser_state;
+
+    // Whether the WebState is created as the result of a window.open

[Eugene But (OOO till 7-30), 2017/03/18 00:33:30]

Could you please update the comment:

Whether this WebState was created via a call to window.open or by clicking a
link with a blank target. Used when determining whether the WebState is allowed
to be closed via window.close(). May be true even with a null |opener| (e.g.,
for blocked popups).

[kkhorimoto, 2017/03/20 22:39:20]

Done, although I left out the last sentence since our CreateParams don't include
|opener|.

+    bool created_with_opener;
   };
 
   // Parameters for the OpenURL() method.
   struct OpenURLParams {
     OpenURLParams(const GURL& url,
                   const Referrer& referrer,
                   WindowOpenDisposition disposition,
                   ui::PageTransition transition,
                   bool is_renderer_initiated);
     ~OpenURLParams();
@@ skipping 153 matching lines @@
   // Removes the callback associated with |command_prefix|.
   virtual void RemoveScriptCommandCallback(
       const std::string& command_prefix) = 0;
 
   // Returns the current CRWWebViewProxy object.
   virtual CRWWebViewProxyType GetWebViewProxy() const = 0;
 
   // Returns Mojo interface registry for this WebState.
   virtual service_manager::InterfaceRegistry* GetMojoInterfaceRegistry() = 0;
 
+  // Returns whether this WebState was created via a call to window.open or by
+  // clicking a link with a blank targer.

[Eugene But (OOO till 7-30), 2017/03/18 00:33:30]

How about this comment?:
Whether this WebState was created with an opener. See
CreateParams::created_with_opener comment for details.

[kkhorimoto, 2017/03/20 22:39:20]

Done.

+  virtual bool HasOpener() const = 0;
+
  protected:
   friend class WebStateObserver;
   friend class WebStatePolicyDecider;
 
   // Adds and removes observers for page navigation notifications. The order in
   // which notifications are sent to observers is undefined. Clients must be
   // sure to remove the observer before they go away.
   // TODO(droger): Move these methods to WebStateImpl once it is in ios/.
   virtual void AddObserver(WebStateObserver* observer) = 0;
   virtual void RemoveObserver(WebStateObserver* observer) = 0;
@@ skipping 12 matching lines @@
 
   // Returns a WeakPtr<WebState> to the current WebState. Must remain private
   // and only call must be in WebStateWeakPtrFactory. Please consult that class
   // for more details. Remove as part of http://crbug.com/556736.
   virtual base::WeakPtr<WebState> AsWeakPtr() = 0;
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_