Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

Issue 2755813002: Begin to wean child processes off reliance on a persistent service_manager::Connection to the brows… (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h
diff --git a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h
index c75493c612cb035980d0e0ff0ccda4a5d4e04f97..17b995a29e8fdcec4912b0e53d03710670b2c04b 100644
--- a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h
+++ b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h
@@ -12,7 +12,7 @@
#include "mojo/public/cpp/bindings/binding.h"
#include "services/resource_coordinator/public/cpp/memory/coordinator.h"
#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"
-#include "services/service_manager/public/cpp/interface_provider.h"
+#include "services/service_manager/public/cpp/connector.h"
namespace memory_instrumentation {
@@ -30,20 +30,24 @@ class MemoryDumpManagerDelegateImpl
public:
class Config {
public:
- Config(service_manager::InterfaceProvider* interface_provider)
- : interface_provider_(interface_provider), coordinator_(nullptr) {}
+ Config(service_manager::Connector* connector,
+ const std::string& service_name)
+ : connector_(connector),
+ service_name_(service_name),
+ coordinator_(nullptr) {}
Config(Coordinator* coordinator)
- : interface_provider_(nullptr), coordinator_(coordinator) {}
+ : connector_(nullptr), coordinator_(coordinator) {}
~Config();
- service_manager::InterfaceProvider* interface_provider() const {
- return interface_provider_;
- }
+ service_manager::Connector* connector() const { return connector_; }
+
+ const std::string& service_name() const { return service_name_; }
Coordinator* coordinator() const { return coordinator_; }
private:
- service_manager::InterfaceProvider* interface_provider_;
+ service_manager::Connector* connector_;
+ const std::string service_name_;
Coordinator* coordinator_;
bool is_test_config_;
};
« no previous file with comments | « content/test/BUILD.gn ('k') | services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698