Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2934)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2755813002: Begin to wean child processes off reliance on a persistent service_manager::Connection to the brows… (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 193653fb04e9a51d83e43632e416790d34ab681b..103e03e3326193ed2ef8d85f1639d82cac956d77 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -84,6 +84,7 @@
#include "content/public/common/content_paths.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/renderer_preferences.h"
+#include "content/public/common/service_names.mojom.h"
#include "content/public/common/url_constants.h"
#include "content/public/renderer/content_renderer_client.h"
#include "content/public/renderer/render_thread_observer.h"
@@ -628,12 +629,10 @@ void RenderThreadImpl::Init(
// Register this object as the main thread.
ChildProcess::current()->set_main_thread(this);
- if (IsRunningInMash()) {
- gpu_ = ui::Gpu::Create(GetServiceManagerConnection()->GetConnector(),
- GetIOTaskRunner());
- } else {
- gpu_ = ui::Gpu::Create(GetRemoteInterfaces(), GetIOTaskRunner());
- }
+ gpu_ = ui::Gpu::Create(
+ GetConnector(),
+ IsRunningInMash() ? ui::mojom::kServiceName : mojom::kBrowserServiceName,
+ GetIOTaskRunner());
channel()->GetThreadSafeRemoteAssociatedInterface(
&thread_safe_render_message_filter_);
@@ -840,7 +839,8 @@ void RenderThreadImpl::Init(
// ChildMemoryCoordinatorImpl.
// https://codereview.chromium.org/2094583002/#msg52
mojom::MemoryCoordinatorHandlePtr parent_coordinator;
- GetRemoteInterfaces()->GetInterface(mojo::MakeRequest(&parent_coordinator));
+ GetConnector()->BindInterface(mojom::kBrowserServiceName,
+ mojo::MakeRequest(&parent_coordinator));
memory_coordinator_ = CreateChildMemoryCoordinator(
std::move(parent_coordinator), this);
}
@@ -868,8 +868,8 @@ void RenderThreadImpl::Init(
NOTREACHED();
#endif
} else {
- ChildThread::Get()->GetRemoteInterfaces()->GetInterface(
- mojo::MakeRequest(&manager_ptr));
+ ChildThread::Get()->GetConnector()->BindInterface(
+ mojom::kBrowserServiceName, mojo::MakeRequest(&manager_ptr));
}
discardable_shared_memory_manager_ = base::MakeUnique<
@@ -890,8 +890,8 @@ void RenderThreadImpl::Init(
base::Bind(&EmbeddedWorkerInstanceClientImpl::Create,
base::Unretained(embedded_worker_dispatcher_.get())));
- GetRemoteInterfaces()->GetInterface(
- mojo::MakeRequest(&storage_partition_service_));
+ GetConnector()->BindInterface(mojom::kBrowserServiceName,
+ mojo::MakeRequest(&storage_partition_service_));
#if defined(OS_LINUX)
ChildProcess::current()->SetIOThreadPriority(base::ThreadPriority::DISPLAY);
@@ -1142,7 +1142,7 @@ void RenderThreadImpl::InitializeWebKit(
->SetRuntimeFeaturesDefaultsBeforeBlinkInitialization();
blink_platform_impl_.reset(new RendererBlinkPlatformImpl(
- renderer_scheduler_.get(), GetRemoteInterfaces()->GetWeakPtr()));
+ renderer_scheduler_.get(), GetConnector()->GetWeakPtr()));
blink::initialize(blink_platform_impl_.get());
v8::Isolate* isolate = blink::mainThreadIsolate();
@@ -2066,7 +2066,8 @@ void RenderThreadImpl::OnFieldTrialGroupFinalized(
const std::string& trial_name,
const std::string& group_name) {
mojom::FieldTrialRecorderPtr field_trial_recorder;
- GetRemoteInterfaces()->GetInterface(&field_trial_recorder);
+ GetConnector()->BindInterface(mojom::kBrowserServiceName,
+ &field_trial_recorder);
field_trial_recorder->FieldTrialActivated(trial_name);
}
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698