Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: cc/layers/layer.h

Issue 2755803003: cc: Remove SetNeedsCommitNoRebuild from Layer API (Closed)
Patch Set: check for LTH Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.h
diff --git a/cc/layers/layer.h b/cc/layers/layer.h
index c310377ed025558769b7d9496840ccb3166a0032..faee6ac7fd98bf6f17226aec8aca96dc130e9474 100644
--- a/cc/layers/layer.h
+++ b/cc/layers/layer.h
@@ -404,6 +404,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
visible_layer_rect_ = rect;
}
+ // This is for tracking damage.
void SetSubtreePropertyChanged();
bool subtree_property_changed() const { return subtree_property_changed_; }
@@ -444,6 +445,8 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
void SetScrollbarsHiddenFromImplSide(bool hidden);
+ void set_is_scroll_clip_layer() { is_scroll_clip_layer_ = true; }
+
const gfx::Rect& update_rect() const { return inputs_.update_rect; }
LayerTreeHost* layer_tree_host() const { return layer_tree_host_; }
@@ -460,9 +463,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
// immediately that a commit is required. This implies SetNeedsPushProperties
// to push that property.
void SetNeedsCommit();
- // This is identical to SetNeedsCommit, but the former requests a rebuild of
- // the property trees.
- void SetNeedsCommitNoRebuild();
+
// Called when there's been a change in layer structure. Implies
// SetNeedsCommit and property tree rebuld, but not SetNeedsPushProperties
// (the full tree is synced over).
@@ -532,6 +533,10 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
// indices becomes invalid.
void InvalidatePropertyTreesIndices();
+ // This is set whenever a property changed on layer that affects whether this
+ // layer should own a property tree node or not.
+ void SetPropertyTreesNeedRebuild();
+
// Encapsulates all data, callbacks or interfaces received from the embedder.
// TODO(khushalsagar): This is only valid when PropertyTrees are built
// internally in cc. Update this for the SPv2 path where blink generates
@@ -647,6 +652,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer> {
bool force_render_surface_for_testing_ : 1;
bool subtree_property_changed_ : 1;
bool may_contain_video_ : 1;
+ bool is_scroll_clip_layer_ : 1;
SkColor safe_opaque_background_color_;
// draw_blend_mode may be different than blend_mode_,
// when a RenderSurface re-parents the layer's blend_mode.
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698