third_party/WebKit/Source/core/frame/Window.idl - Issue 2755773002: Make Window#open arguments optional to match the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2755773002: Make Window#open arguments optional to match the spec

Patch Set: Update wpt tests window-open.html Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-open.html ('K') | « third_party/WebKit/LayoutTests/fast/js/function-length-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Window.idl

diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl

index c86c8b21790ac6626c5f682a9df2207544a54917..acf4901f393d7720fb5c82724934a7a549d16938 100644

--- a/third_party/WebKit/Source/core/frame/Window.idl

+++ b/third_party/WebKit/Source/core/frame/Window.idl

@@ -62,8 +62,7 @@

[CrossOrigin, Custom=Setter] attribute Window opener;

[Replaceable, CrossOrigin] readonly attribute Window? parent;

[CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frameElement;

- // FIXME: open() should have 4 optional arguments with defaults.

- [Custom] Window? open(DOMString url, DOMString target, optional DOMString features);

+ [Custom] Window? open(optional DOMString url = "about:blank", optional DOMString target = "_blank", [TreatNullAs=EmptyString] optional DOMString features = "");

// FIXME: These getters should not have [NotEnumerable].

[NotEnumerable, CrossOrigin] getter Window (unsigned long index);

[Custom, NotEnumerable, CrossOrigin] getter object (DOMString name);