Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2755773002: Make Window#open arguments optional to match the spec
Patch Set: Updated layout tests for window.open Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Window.idl
diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl
index c86c8b21790ac6626c5f682a9df2207544a54917..acf4901f393d7720fb5c82724934a7a549d16938 100644
--- a/third_party/WebKit/Source/core/frame/Window.idl
+++ b/third_party/WebKit/Source/core/frame/Window.idl
@@ -62,8 +62,7 @@
[CrossOrigin, Custom=Setter] attribute Window opener;
[Replaceable, CrossOrigin] readonly attribute Window? parent;
[CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frameElement;
- // FIXME: open() should have 4 optional arguments with defaults.
- [Custom] Window? open(DOMString url, DOMString target, optional DOMString features);
+ [Custom] Window? open(optional DOMString url = "about:blank", optional DOMString target = "_blank", [TreatNullAs=EmptyString] optional DOMString features = "");
// FIXME: These getters should not have [NotEnumerable].
[NotEnumerable, CrossOrigin] getter Window (unsigned long index);
[Custom, NotEnumerable, CrossOrigin] getter object (DOMString name);

Powered by Google App Engine
This is Rietveld 408576698