third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-open.html - Issue 2755773002: Make Window#open arguments optional to match the spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-open.html

Issue 2755773002: Make Window#open arguments optional to match the spec

Patch Set: Updated layout tests for window.open Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Window#open</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 test(function() {

	8 assert_equals(window.open().location.href, 'about:blank');

	9 assert_equals(window.open(undefined).location.href, 'about:blank');

	10 assert_equals(window.open('null').location.href, 'about:blank');
	foolip 2017/04/05 04:33:56 Here I meant to test using the literal null, not a Here I meant to test using the literal null, not a string, because I suspect that will reveal a bug in our custom bindings. However, it also seems like these tests can't be synchronous, because it seems like location.href is always 'about:blank' initially and then the window is navigated to the new url asynchronously. That's the "Otherwise, navigate" at step 8 of https://html.spec.whatwg.org/multipage/browsers.html#dom-open So, for the first two of these, I think you'll have to do something like this: async_test(t => { const win = window.open(); assert_equals(win.location.href, 'about:blank'); win.onload = t.step_func_done(() => { assert_equals(win.location.href, 'about:blank'); }); }); And for the null case, the inner assert should probably be assert_true(win.location.href.endsWith('null')); What I hope to find out is which browsers will fail the window.open(null) case. It could be that we should change the spec if everyone treats it as 'about:blank' rather than stringifying it to 'null'.
	11 }, 'window.open() should have default url = "about:blank"');

	12

	13 test(function() {

	14 assert_equals(window.open('about:blank', undefined).name, '');

	15 assert_equals(window.open('about:blank', null).name, '');

	16 }, 'window.open() browsing context name');

	17 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/js/function-length.html » ('j') | no next file with comments »