| Index: components/offline_pages/core/background/pick_request_task_unittest.cc
|
| diff --git a/components/offline_pages/core/background/pick_request_task_unittest.cc b/components/offline_pages/core/background/pick_request_task_unittest.cc
|
| index 7f68624655161a62bfdd135646afb28cee476a48..2cae77bd3e0cb94477b7cf5fe31852301375112b 100644
|
| --- a/components/offline_pages/core/background/pick_request_task_unittest.cc
|
| +++ b/components/offline_pages/core/background/pick_request_task_unittest.cc
|
| @@ -42,7 +42,6 @@ const int kMaxCompletedTries = 1;
|
| const bool kPreferUntried = false;
|
| const bool kPreferEarlier = true;
|
| const bool kPreferRetryCount = true;
|
| -const int kBackgroundProcessingTimeBudgetSeconds = 170;
|
|
|
| // Default request
|
| const SavePageRequest kEmptyRequest(0UL,
|
| @@ -245,9 +244,9 @@ TEST_F(PickRequestTaskTest, PickFromEmptyQueue) {
|
|
|
| TEST_F(PickRequestTaskTest, ChooseRequestWithHigherRetryCount) {
|
| // Set up policy to prefer higher retry count.
|
| - policy_.reset(new OfflinerPolicy(
|
| - kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
|
| + kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries + 1));
|
| MakePickRequestTask();
|
|
|
| base::Time creation_time = base::Time::Now();
|
| @@ -290,9 +289,9 @@ TEST_F(PickRequestTaskTest, ChooseRequestWithSameRetryCountButEarlier) {
|
|
|
| TEST_F(PickRequestTaskTest, ChooseEarlierRequest) {
|
| // We need a custom policy object prefering recency to retry count.
|
| - policy_.reset(new OfflinerPolicy(
|
| - kPreferUntried, kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
|
| + !kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries));
|
| MakePickRequestTask();
|
|
|
| base::Time creation_time1 =
|
| @@ -316,9 +315,9 @@ TEST_F(PickRequestTaskTest, ChooseEarlierRequest) {
|
|
|
| TEST_F(PickRequestTaskTest, ChooseSameTimeRequestWithHigherRetryCount) {
|
| // We need a custom policy object preferring recency to retry count.
|
| - policy_.reset(new OfflinerPolicy(
|
| - kPreferUntried, kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
|
| + !kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries + 1));
|
| MakePickRequestTask();
|
|
|
| base::Time creation_time = base::Time::Now();
|
| @@ -340,9 +339,9 @@ TEST_F(PickRequestTaskTest, ChooseSameTimeRequestWithHigherRetryCount) {
|
|
|
| TEST_F(PickRequestTaskTest, ChooseRequestWithLowerRetryCount) {
|
| // We need a custom policy object preferring lower retry count.
|
| - policy_.reset(new OfflinerPolicy(
|
| - !kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(!kPreferUntried, kPreferEarlier,
|
| + kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries + 1));
|
| MakePickRequestTask();
|
|
|
| base::Time creation_time = base::Time::Now();
|
| @@ -364,9 +363,9 @@ TEST_F(PickRequestTaskTest, ChooseRequestWithLowerRetryCount) {
|
|
|
| TEST_F(PickRequestTaskTest, ChooseLaterRequest) {
|
| // We need a custom policy preferring recency over retry, and later requests.
|
| - policy_.reset(new OfflinerPolicy(
|
| - kPreferUntried, !kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(kPreferUntried, !kPreferEarlier,
|
| + !kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries));
|
| MakePickRequestTask();
|
|
|
| base::Time creation_time1 =
|
| @@ -461,9 +460,9 @@ TEST_F(PickRequestTaskTest, ChooseRequestThatHasNotExceededCompletionLimit) {
|
| }
|
|
|
| TEST_F(PickRequestTaskTest, ChooseRequestThatIsNotDisabled) {
|
| - policy_.reset(new OfflinerPolicy(
|
| - kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
|
| - kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
|
| + policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
|
| + kPreferRetryCount, kMaxStartedTries,
|
| + kMaxCompletedTries + 1));
|
|
|
| // put request 2 on disabled list, ensure request1 picked instead,
|
| // even though policy would prefer 2.
|
|
|