Source/core/accessibility/AXRenderObject.cpp - Issue 275573003: Oilpan: Prepare to move select and option elements to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 275573003: Oilpan: Prepare to move select and option elements to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXRenderObject.cpp

diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp

index 9b024295b71353bf3ca49bf93f37dd4cd34cb63b..99c6da4e3462700679dc08c776b92211f511c083 100644

--- a/Source/core/accessibility/AXRenderObject.cpp

+++ b/Source/core/accessibility/AXRenderObject.cpp

@@ -876,7 +876,7 @@ String AXRenderObject::stringValue() const

// This has to be overridden in the case where the selected item has an ARIA label.

HTMLSelectElement* selectElement = toHTMLSelectElement(m_renderer->node());

int selectedIndex = selectElement->selectedIndex();

- const Vector<HTMLElement*> listItems = selectElement->listItems();

+ const WillBeHeapVector<RawPtrWillBeMember<HTMLElement> >& listItems = selectElement->listItems();

if (selectedIndex >= 0 && static_cast<size_t>(selectedIndex) < listItems.size()) {

const AtomicString& overriddenDescription = listItems[selectedIndex]->fastGetAttribute(aria_labelAttr);

if (!overriddenDescription.isNull())