Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/browser/android/content_feature_list.cc

Issue 2755673005: [Android] Trigger native event batching through Feature API (Closed)
Patch Set: Address isherman@'s comments: Fix nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_feature_list.cc
diff --git a/content/browser/android/content_feature_list.cc b/content/browser/android/content_feature_list.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c184a48a684783e3b55a8cbf1c8c531e6aaef933
--- /dev/null
+++ b/content/browser/android/content_feature_list.cc
@@ -0,0 +1,56 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/android/content_feature_list.h"
+
+#include "base/android/jni_string.h"
+#include "base/feature_list.h"
+#include "base/macros.h"
+#include "jni/ContentFeatureList_jni.h"
+
+using base::android::ConvertJavaStringToUTF8;
+using base::android::JavaParamRef;
+
+namespace content {
+namespace android {
+
+namespace {
+
+// Array of features exposed through the Java ContentFeatureList API. Entries in
+// this array may either refer to features defined in the header of this file or
+// in other locations in the code base (e.g. content_features.h).
+const base::Feature* kFeaturesExposedToJava[] = {
+ &kRequestUnbufferedDispatch,
+};
+
+const base::Feature* FindFeatureExposedToJava(const std::string& feature_name) {
+ for (size_t i = 0; i < arraysize(kFeaturesExposedToJava); ++i) {
+ if (kFeaturesExposedToJava[i]->name == feature_name)
+ return kFeaturesExposedToJava[i];
+ }
+ NOTREACHED() << "Queried feature cannot be found in ContentFeatureList: "
+ << feature_name;
Ilya Sherman 2017/03/16 17:38:53 Thanks! Would you mind similarly updating the chr
chongz 2017/03/16 18:54:04 Done.
+ return nullptr;
+}
+
+} // namespace
+
+// Alphabetical:
+const base::Feature kRequestUnbufferedDispatch{
+ "RequestUnbufferedDispatch", base::FEATURE_DISABLED_BY_DEFAULT};
+
+static jboolean IsEnabled(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jstring>& jfeature_name) {
+ const base::Feature* feature =
+ FindFeatureExposedToJava(ConvertJavaStringToUTF8(env, jfeature_name));
+ return base::FeatureList::IsEnabled(*feature);
+}
+
+bool RegisterContentFeatureListJni(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+} // namespace android
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698