cleanup GrContext resource cache api

cleanup GrContext resource cache api

Committed: http://code.google.com/p/skia/source/detail?r=14669

[bsalomon, 2014-05-08 18:26:45]

https://codereview.chromium.org/275563005/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/275563005/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:128: void getResourceCacheUsage(int* resourceCount,
size_t* resourceBytes) const;
It seemed like the usage getter should mirror the limits getter and setter.
Also, I wrote getResourceCacheResourceCount() and was displeased.

[robertphillips, 2014-05-08 19:12:35]

lgtm

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:125: *  @param resourceCount If non-null, returns the
number of resources that are held in the
extra space?

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:126: *                        cache.
just resourceBytes
"returns The" -> "returns the" ?

https://codereview.chromium.org/275563005/diff/40001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/275563005/diff/40001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:578: void GrContext::getResourceCacheLimits(int*
maxTextures,
missing space? maybe one line?

[bsalomon, 2014-05-09 13:44:49]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-09 13:45:37]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/275563005/60001

[commit-bot: I haz the power, 2014-05-09 13:52:45]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[commit-bot: I haz the power, 2014-05-09 13:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 13:59:21]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[bsalomon, 2014-05-09 14:13:51]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-09 14:14:44]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/275563005/80001

[commit-bot: I haz the power, 2014-05-09 14:29:36]

Change committed as 14669

[bsalomon, 2014-05-09 15:23:52]

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:125: *  @param resourceCount If non-null, returns the
number of resources that are held in the
On 2014/05/08 19:12:35, robertphillips wrote:
> extra space?

Done.

https://codereview.chromium.org/275563005/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:126: *                        cache.
On 2014/05/08 19:12:35, robertphillips wrote:
> just resourceBytes
> "returns The" -> "returns the" ?

Done.

https://codereview.chromium.org/275563005/diff/40001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/275563005/diff/40001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:578: void GrContext::getResourceCacheLimits(int*
maxTextures,
On 2014/05/08 19:12:35, robertphillips wrote:
> missing space? maybe one line?

Done.