Chromium Code Reviews Chromium Code Reviews
Issue 275563003:
Change caret to show language direction (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. | 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 57 bool shouldUpdateCaretRect() const { return m_caretRectNeedsUpdate; } | 57 bool shouldUpdateCaretRect() const { return m_caretRectNeedsUpdate; } |
| 58 void setCaretRectNeedsUpdate() { m_caretRectNeedsUpdate = true; } | 58 void setCaretRectNeedsUpdate() { m_caretRectNeedsUpdate = true; } |
| 59 | 59 |
| 60 void setCaretVisibility(CaretVisibility visibility) { m_caretVisibility = vi sibility; } | 60 void setCaretVisibility(CaretVisibility visibility) { m_caretVisibility = vi sibility; } |
| 61 bool caretIsVisible() const { return m_caretVisibility == Visible; } | 61 bool caretIsVisible() const { return m_caretVisibility == Visible; } |
| 62 CaretVisibility caretVisibility() const { return m_caretVisibility; } | 62 CaretVisibility caretVisibility() const { return m_caretVisibility; } |
| 63 | 63 |
| 64 protected: | 64 protected: |
| 65 static RenderObject* caretRenderer(Node*); | 65 static RenderObject* caretRenderer(Node*); |
| 66 static void repaintCaretForLocalRect(Node*, const LayoutRect&); | 66 static void repaintCaretForLocalRect(Node*, const LayoutRect&); |
| 67 static void updateDirectionPointer(const RenderObject* caretPainter , Layout Rect&); | |
|
Inactive
2014/05/23 19:57:01
nit: Extra space before comma
h.joshi
2014/05/24 02:18:20
Okey, will remove extra space.
| |
| 67 | 68 |
| 68 private: | 69 private: |
| 69 LayoutRect m_caretLocalRect; // caret rect in coords local to the renderer r esponsible for painting the caret | 70 LayoutRect m_caretLocalRect; // caret rect in coords local to the renderer r esponsible for painting the caret |
| 70 bool m_caretRectNeedsUpdate; // true if m_caretRect (and m_absCaretBounds in FrameSelection) need to be calculated | 71 bool m_caretRectNeedsUpdate; // true if m_caretRect (and m_absCaretBounds in FrameSelection) need to be calculated |
| 71 CaretVisibility m_caretVisibility; | 72 CaretVisibility m_caretVisibility; |
| 72 }; | 73 }; |
| 73 | 74 |
| 74 class DragCaretController : private CaretBase { | 75 class DragCaretController : private CaretBase { |
| 75 WTF_MAKE_NONCOPYABLE(DragCaretController); | 76 WTF_MAKE_NONCOPYABLE(DragCaretController); |
| 76 WTF_MAKE_FAST_ALLOCATED; | 77 WTF_MAKE_FAST_ALLOCATED; |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 93 private: | 94 private: |
| 94 DragCaretController(); | 95 DragCaretController(); |
| 95 | 96 |
| 96 VisiblePosition m_position; | 97 VisiblePosition m_position; |
| 97 }; | 98 }; |
| 98 | 99 |
| 99 } // namespace WebCore | 100 } // namespace WebCore |
| 100 | 101 |
| 101 | 102 |
| 102 #endif // Caret_h | 103 #endif // Caret_h |
| OLD | NEW |
