Change caret to show language direction

Source/core/editing/Caret.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 172 matching lines @@
 {
     RenderObject* caretPainter = caretRenderer(node);
     if (!caretPainter)
         return;
 
     // FIXME: Need to over-paint 1 pixel to workaround some rounding problems.
     // https://bugs.webkit.org/show_bug.cgi?id=108283
     LayoutRect inflatedRect = rect;
     inflatedRect.inflate(1);
 
+    // as extra rect are draw so need to refresh more area

[Inactive, 2014/05/22 14:15:05]

Comments should start with a capital letter and end with a '.'.

also "are draw" -> "are drawn"

[h.joshi, 2014/05/23 13:26:31]

Okey, will fix this

+    TextDirection containerDirection = toRenderBoxModelObject(caretRenderer(node))->style()->direction();

[Inactive, 2014/05/22 14:15:05]

You likely want to use caretPainter variable here.

[h.joshi, 2014/05/23 13:26:31]

Okey, will fix this

+    inflatedRect.setWidth(inflatedRect.width() + LayoutUnit(2));
+    if (containerDirection  == RTL)
+        inflatedRect.setX(inflatedRect.x() - LayoutUnit(2));
+
     caretPainter->repaintRectangle(inflatedRect);
 }
 
 bool CaretBase::shouldRepaintCaret(const RenderView* view, bool isContentEditable) const
 {
     ASSERT(view);
     bool caretBrowsing = false;
     if (FrameView* frameView = view->frameView()) {
         LocalFrame& frame = frameView->frame(); // The frame where the selection started
         caretBrowsing = frame.settings() && frame.settings()->caretBrowsingEnabled();
@@ skipping 13 matching lines @@
     // it happens after the document has accounted for any editing
     // changes which may have been done.
     // And, we need to leave this layout here so the caret moves right
     // away after clicking.
     m_caretRectNeedsUpdate = true;
 
     if (caretRectChanged)
         return;
 
     if (RenderView* view = node->document().renderView()) {
-        if (shouldRepaintCaret(view, node->isContentEditable(Node::UserSelectAllIsAlwaysNonEditable)))
-            repaintCaretForLocalRect(node, localCaretRectWithoutUpdate());
+        if (shouldRepaintCaret(view, node->isContentEditable(Node::UserSelectAllIsAlwaysNonEditable))) {
+            // as extra rect are draw so need to refresh more area

[Inactive, 2014/05/22 14:15:05]

Ditto.

+            LayoutRect drawingRect = localCaretRectWithoutUpdate();
+            TextDirection containerDirection = toRenderBoxModelObject(caretRenderer(node))->style()->direction();

[Inactive, 2014/05/22 14:15:05]

Code duplication, you should probably move the code to a utility function to
avoid this.

[h.joshi, 2014/05/23 13:26:31]

Okey, will make new utility method

+            drawingRect.setWidth(drawingRect.width() + LayoutUnit(2));
+
+            if (containerDirection  == RTL)
+                drawingRect.setX(drawingRect.x() - LayoutUnit(2));
+            repaintCaretForLocalRect(node, drawingRect);
+        }
     }
 }
 
 void CaretBase::paintCaret(Node* node, GraphicsContext* context, const LayoutPoint& paintOffset, const LayoutRect& clipRect) const
 {
     if (m_caretVisibility == Hidden)
         return;
 
     LayoutRect drawingRect = localCaretRectWithoutUpdate();
     RenderObject* renderer = caretRenderer(node);
     if (renderer && renderer->isBox())
         toRenderBox(renderer)->flipForWritingMode(drawingRect);
     drawingRect.moveBy(roundedIntPoint(paintOffset));
     LayoutRect caret = intersection(drawingRect, clipRect);
     if (caret.isEmpty())
         return;
 
+    TextDirection containerDirection = toRenderBoxModelObject(renderer)->style()->direction();
+    LayoutRect ptrCaret = caret;

[Inactive, 2014/05/22 14:15:05]

please no not use abbreviations in variable names. Also ptr is a bit confusing 
as it is not technically a pointer.

+
+    // drawing different Caret which shows editing style similar to IE
+    if (containerDirection == LTR) {

[Inactive, 2014/05/22 14:15:05]

No {} for one-liners.

[h.joshi, 2014/05/23 13:26:31]

Okey, will update condition

+    ptrCaret.setX(ptrCaret.x() + 1);

[Inactive, 2014/05/22 14:15:05]

identation problem

+    } else {

[Inactive, 2014/05/22 14:15:05]

ditto

+    ptrCaret.setX(ptrCaret.x() - 2);

[Inactive, 2014/05/22 14:15:05]

ditto.

+    }
+    ptrCaret.setWidth(LayoutUnit(2));
+    ptrCaret.setHeight(LayoutUnit(1));
+
     Color caretColor = Color::black;
 
     Element* element;
     if (node->isElementNode())
         element = toElement(node);
     else
         element = node->parentElement();
 
     if (element && element->renderer())
         caretColor = element->renderer()->resolveColor(CSSPropertyColor);
 
     context->fillRect(caret, caretColor);
+    context->fillRect(ptrCaret, caretColor);
+
+    // Update ptrCaret points and lets draw one more small rect to match IE

[Inactive, 2014/05/22 14:15:05]

end with a '.'

[h.joshi, 2014/05/23 13:26:31]

Okey, will update comment

+    ptrCaret.setY(caret.y() + LayoutUnit(1));
+    ptrCaret.setWidth(LayoutUnit(1));
+    if (containerDirection == RTL)
+        ptrCaret.setX(ptrCaret.x() + 1);
+    context->fillRect(ptrCaret, caretColor);
 }
 
 void DragCaretController::paintDragCaret(LocalFrame* frame, GraphicsContext* p, const LayoutPoint& paintOffset, const LayoutRect& clipRect) const
 {
     if (m_position.deepEquivalent().deprecatedNode()->document().frame() == frame)
         paintCaret(m_position.deepEquivalent().deprecatedNode(), p, paintOffset, clipRect);
 }
 
 }