Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 275563002: Don't layout when isSelfPaintingLayer() changes (Closed)

Created:
6 years, 7 months ago by esprehn
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Don't layout when isSelfPaintingLayer() changes I can't find any reason to do a layout when the self painting bit changes. The code was added by hyatt a long time ago in https://trac.webkit.org/changeset/43657 but the test he added still passes without that code (as do the rest of the tests). Lets just delete this layout code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173614

Patch Set 1 #

Total comments: 1

Patch Set 2 : just remove it #

Patch Set 3 : just remove it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
6 years, 7 months ago (2014-05-08 01:36:15 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/275563002/diff/1/Source/core/rendering/RenderLayerModelObject.cpp File Source/core/rendering/RenderLayerModelObject.cpp (right): https://codereview.chromium.org/275563002/diff/1/Source/core/rendering/RenderLayerModelObject.cpp#newcode166 Source/core/rendering/RenderLayerModelObject.cpp:166: repaint(); Do any tests fail if you just ...
6 years, 7 months ago (2014-05-08 01:37:50 UTC) #2
esprehn
On 2014/05/08 01:37:50, abarth wrote: > LGTM > > https://codereview.chromium.org/275563002/diff/1/Source/core/rendering/RenderLayerModelObject.cpp > File Source/core/rendering/RenderLayerModelObject.cpp (right): > ...
6 years, 7 months ago (2014-05-08 01:39:04 UTC) #3
esprehn
Yeah it seems everything passes without that code, lets delete it.
6 years, 7 months ago (2014-05-08 07:21:26 UTC) #4
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 7 months ago (2014-05-08 07:21:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/275563002/40001
6 years, 7 months ago (2014-05-08 07:22:08 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 08:00:44 UTC) #7
Message was sent while issue was closed.
Change committed as 173614

Powered by Google App Engine
This is Rietveld 408576698