third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl - Issue 2755603003: [Refactor] Update template files for callback functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2755603003: [Refactor] Update template files for callback functions (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

index 57b5e77c614c6869930c45b4757df5e469d33574..592b9d6c2a69d98457c59728103a253c7b2ca180 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

@@ -18,11 +18,11 @@ class {{forward_declaration}};

class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}>, public TraceWrapperBase {

public:

- static {{cpp_class}}* create(ScriptState* scriptState, v8::Local<v8::Value> callback);

+ static {{cpp_class}}* create(ScriptState*, v8::Local<v8::Value>);

Yuki 2017/03/15 08:14:46 nit: Do not drop |callback| because it's meanful a

peria 2017/03/15 08:39:06 Done.

~{{cpp_class}}() = default;

- DECLARE_TRACE();

+ DEFINE_INLINE_TRACE() {}

DECLARE_TRACE_WRAPPERS();

bool call({{argument_declarations | join(', ')}});