Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2755593002: Remove pointer from PermissionPromptAndroid to InfoBar (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_prompt_android.h" 5 #include "chrome/browser/permissions/permission_prompt_android.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/infobars/infobar_service.h" 8 #include "chrome/browser/infobars/infobar_service.h"
9 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
10 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h" 9 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h"
11 #include "chrome/browser/permissions/permission_request.h" 10 #include "chrome/browser/permissions/permission_request.h"
12 #include "chrome/browser/permissions/permission_request_id.h"
13 #include "components/infobars/core/infobar.h"
14 #include "content/public/browser/web_contents.h"
15 11
16 PermissionPromptAndroid::PermissionPromptAndroid( 12 PermissionPromptAndroid::PermissionPromptAndroid(
17 content::WebContents* web_contents) 13 content::WebContents* web_contents)
18 : web_contents_(web_contents), delegate_(nullptr), infobar_(nullptr) { 14 : web_contents_(web_contents), delegate_(nullptr) {
19 DCHECK(web_contents); 15 DCHECK(web_contents);
20 } 16 }
21 17
22 PermissionPromptAndroid::~PermissionPromptAndroid() { 18 PermissionPromptAndroid::~PermissionPromptAndroid() {}
23 if (infobar_) {
24 GroupedPermissionInfoBarDelegate* infobar_delegate =
25 static_cast<GroupedPermissionInfoBarDelegate*>(infobar_->delegate());
26 infobar_delegate->PermissionPromptDestroyed();
27 }
28 }
29 19
30 void PermissionPromptAndroid::SetDelegate(Delegate* delegate) { 20 void PermissionPromptAndroid::SetDelegate(Delegate* delegate) {
31 delegate_ = delegate; 21 delegate_ = delegate;
32 } 22 }
33 23
34 void PermissionPromptAndroid::Show( 24 void PermissionPromptAndroid::Show(
35 const std::vector<PermissionRequest*>& requests, 25 const std::vector<PermissionRequest*>& requests,
36 const std::vector<bool>& values) { 26 const std::vector<bool>& values) {
37 InfoBarService* infobar_service = 27 InfoBarService* infobar_service =
38 InfoBarService::FromWebContents(web_contents_); 28 InfoBarService::FromWebContents(web_contents_);
39 if (!infobar_service) 29 if (!infobar_service)
40 return; 30 return;
41 31
42 requests_ = requests; 32 requests_ = requests;
43 infobar_ = GroupedPermissionInfoBarDelegate::Create(this, infobar_service, 33 GroupedPermissionInfoBarDelegate::Create(this, infobar_service,
44 requests[0]->GetOrigin()); 34 requests[0]->GetOrigin());
45 } 35 }
46 36
47 bool PermissionPromptAndroid::CanAcceptRequestUpdate() { 37 bool PermissionPromptAndroid::CanAcceptRequestUpdate() {
48 return false; 38 return false;
49 } 39 }
50 40
41 bool PermissionPromptAndroid::HidesAutomatically() {
42 return true;
43 }
44
51 void PermissionPromptAndroid::Hide() { 45 void PermissionPromptAndroid::Hide() {
52 InfoBarService* infobar_service = 46 // Hide() is only called if HidesAutomatically() returns false or
53 InfoBarService::FromWebContents(web_contents_); 47 // CanAcceptRequestUpdate() return true.
54 if (infobar_ && infobar_service) { 48 NOTREACHED();
55 infobar_service->RemoveInfoBar(infobar_);
56 }
57 infobar_ = nullptr;
58 } 49 }
59 50
60 bool PermissionPromptAndroid::IsVisible() { 51 bool PermissionPromptAndroid::IsVisible() {
61 return infobar_ != nullptr; 52 return !requests_.empty();
62 } 53 }
63 54
64 void PermissionPromptAndroid::UpdateAnchorPosition() { 55 void PermissionPromptAndroid::UpdateAnchorPosition() {
65 NOTREACHED() << "UpdateAnchorPosition is not implemented"; 56 NOTREACHED() << "UpdateAnchorPosition is not implemented";
66 } 57 }
67 58
68 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() { 59 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
69 NOTREACHED() << "GetNativeWindow is not implemented"; 60 NOTREACHED() << "GetNativeWindow is not implemented";
70 return nullptr; 61 return nullptr;
71 } 62 }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 size_t position) const { 99 size_t position) const {
109 DCHECK_LT(position, requests_.size()); 100 DCHECK_LT(position, requests_.size());
110 return requests_[position]->GetMessageTextFragment(); 101 return requests_[position]->GetMessageTextFragment();
111 } 102 }
112 103
113 // static 104 // static
114 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create( 105 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
115 content::WebContents* web_contents) { 106 content::WebContents* web_contents) {
116 return base::MakeUnique<PermissionPromptAndroid>(web_contents); 107 return base::MakeUnique<PermissionPromptAndroid>(web_contents);
117 } 108 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_prompt_android.h ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698