Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: services/ui/ws/frame_generator.cc

Issue 2755573002: Add FrameGenerator Unit Tests (Closed)
Patch Set: FrameGenerator ignores MISSED BeginFrameArgs Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/frame_generator.cc
diff --git a/services/ui/ws/frame_generator.cc b/services/ui/ws/frame_generator.cc
index 30b17f3da99bf188dcddf76cbfd9508f4e87a110..3af9569291bcb3415da8e62a9760f8166db50f10 100644
--- a/services/ui/ws/frame_generator.cc
+++ b/services/ui/ws/frame_generator.cc
@@ -93,8 +93,10 @@ void FrameGenerator::SetExternalTilePriorityConstraints(
const gfx::Transform& transform) {}
void FrameGenerator::OnBeginFrame(const cc::BeginFrameArgs& begin_frame_args) {
- if (!root_window_->visible())
+ if (!root_window_->visible() ||
+ begin_frame_args.type == cc::BeginFrameArgs::MISSED) {
return;
+ }
// TODO(fsamuel): We should add a trace for generating a top level frame.
cc::CompositorFrame frame(GenerateCompositorFrame(root_window_->bounds()));

Powered by Google App Engine
This is Rietveld 408576698