Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: specific_type_identifier can be used outside of contextual suggestions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 275328f4c34bb1ecf762f3ed4977609ddaeb1cfc..3a6307fe1a75367dc559156d43f8d00c7688e656 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -2668,7 +2668,7 @@ TEST_F(SearchProviderTest, NavigationInline) {
SearchSuggestionParser::NavigationResult result(
ChromeAutocompleteSchemeClassifier(&profile_), GURL(cases[i].url),
AutocompleteMatchType::NAVSUGGEST, base::string16(), std::string(),
- false, 0, false, ASCIIToUTF16(cases[i].input));
+ false, 0, false, ASCIIToUTF16(cases[i].input), 0);
result.set_received_after_last_keystroke(false);
AutocompleteMatch match(provider_->NavigationToMatch(result));
EXPECT_EQ(ASCIIToUTF16(cases[i].inline_autocompletion),
@@ -2682,7 +2682,7 @@ TEST_F(SearchProviderTest, NavigationInline) {
SearchSuggestionParser::NavigationResult result_prevent_inline(
ChromeAutocompleteSchemeClassifier(&profile_), GURL(cases[i].url),
AutocompleteMatchType::NAVSUGGEST, base::string16(), std::string(),
- false, 0, false, ASCIIToUTF16(cases[i].input));
+ false, 0, false, ASCIIToUTF16(cases[i].input), 0);
result_prevent_inline.set_received_after_last_keystroke(false);
AutocompleteMatch match_prevent_inline(
provider_->NavigationToMatch(result_prevent_inline));
@@ -2701,8 +2701,8 @@ TEST_F(SearchProviderTest, NavigationInlineSchemeSubstring) {
const base::string16 url(ASCIIToUTF16("http://a.com"));
SearchSuggestionParser::NavigationResult result(
ChromeAutocompleteSchemeClassifier(&profile_), GURL(url),
- AutocompleteMatchType::NAVSUGGEST,
- base::string16(), std::string(), false, 0, false, input);
+ AutocompleteMatchType::NAVSUGGEST, base::string16(), std::string(), false,
+ 0, false, input, 0);
result.set_received_after_last_keystroke(false);
// Check the offset and strings when inline autocompletion is allowed.
@@ -2725,9 +2725,9 @@ TEST_F(SearchProviderTest, NavigationInlineSchemeSubstring) {
TEST_F(SearchProviderTest, NavigationInlineDomainClassify) {
QueryForInput(ASCIIToUTF16("w"), false, false);
SearchSuggestionParser::NavigationResult result(
- ChromeAutocompleteSchemeClassifier(&profile_),
- GURL("http://www.wow.com"), AutocompleteMatchType::NAVSUGGEST,
- base::string16(), std::string(), false, 0, false, ASCIIToUTF16("w"));
+ ChromeAutocompleteSchemeClassifier(&profile_), GURL("http://www.wow.com"),
+ AutocompleteMatchType::NAVSUGGEST, base::string16(), std::string(), false,
+ 0, false, ASCIIToUTF16("w"), 0);
result.set_received_after_last_keystroke(false);
AutocompleteMatch match(provider_->NavigationToMatch(result));
EXPECT_EQ(ASCIIToUTF16("ow.com"), match.inline_autocompletion);
« no previous file with comments | « no previous file | components/metrics/proto/omnibox_event.proto » ('j') | components/omnibox/browser/autocomplete_match.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698