Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: components/omnibox/browser/base_search_provider_unittest.cc

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: Small fixes and sync. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/base_search_provider_unittest.cc
diff --git a/components/omnibox/browser/base_search_provider_unittest.cc b/components/omnibox/browser/base_search_provider_unittest.cc
index a4d9e8e5e4cf53bf093b97fd61a1e45eb33e687c..1848c9f1d90e6dc1a377772641a99ae1974d29d6 100644
--- a/components/omnibox/browser/base_search_provider_unittest.cc
+++ b/components/omnibox/browser/base_search_provider_unittest.cc
@@ -102,7 +102,7 @@ TEST_F(BaseSearchProviderTest, PreserveAnswersWhenDeduplicating) {
.WillRepeatedly(Return(template_url.get()));
SearchSuggestionParser::SuggestResult more_relevant(
- query, AutocompleteMatchType::SEARCH_HISTORY, query, base::string16(),
+ query, AutocompleteMatchType::SEARCH_HISTORY, 0, query, base::string16(),
base::string16(), base::string16(), base::string16(), nullptr,
std::string(), std::string(), false, 1300, true, false, query);
provider_->AddMatchToMap(
@@ -110,10 +110,10 @@ TEST_F(BaseSearchProviderTest, PreserveAnswersWhenDeduplicating) {
false, false, &map);
SearchSuggestionParser::SuggestResult less_relevant(
- query, AutocompleteMatchType::SEARCH_SUGGEST, query, base::string16(),
+ query, AutocompleteMatchType::SEARCH_SUGGEST, 0, query, base::string16(),
base::string16(), answer_contents, answer_type,
- SuggestionAnswer::copy(answer.get()), std::string(), std::string(),
- false, 850, true, false, query);
+ SuggestionAnswer::copy(answer.get()), std::string(), std::string(), false,
+ 850, true, false, query);
provider_->AddMatchToMap(
less_relevant, std::string(), TemplateURLRef::NO_SUGGESTION_CHOSEN,
false, false, &map);
@@ -142,7 +142,7 @@ TEST_F(BaseSearchProviderTest, PreserveAnswersWhenDeduplicating) {
std::unique_ptr<SuggestionAnswer> answer2(new SuggestionAnswer());
answer2->set_type(8242);
more_relevant = SearchSuggestionParser::SuggestResult(
- query, AutocompleteMatchType::SEARCH_HISTORY, query, base::string16(),
+ query, AutocompleteMatchType::SEARCH_HISTORY, 0, query, base::string16(),
base::string16(), answer_contents2, answer_type2,
SuggestionAnswer::copy(answer2.get()), std::string(), std::string(),
false, 1300, true, false, query);
« no previous file with comments | « components/omnibox/browser/base_search_provider.cc ('k') | components/omnibox/browser/omnibox_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698