Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: Small fixes and sync. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/omnibox_event.proto
diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto
index 0410d6cc0edfd97b55f6d4b7dec11a15de84dcee..1998a08fb219cf5d2bfec562b952cef7e7029aab 100644
--- a/components/metrics/proto/omnibox_event.proto
+++ b/components/metrics/proto/omnibox_event.proto
@@ -177,7 +177,7 @@ message OmniboxEventProto {
}
// The result set displayed on the completion popup
- // Next tag: 7
+ // Next tag: 8
message Suggestion {
// Where does this result come from?
optional ProviderType provider = 1;
@@ -196,6 +196,14 @@ message OmniboxEventProto {
HISTORY_KEYWORD = 5; // A past page whose keyword contains the
// input
NAVSUGGEST = 6; // A suggested URL
+ //
+ // result_subtype_identifier is currently used
+ // for contextual zero-suggest suggestions
+ // provided by the experimental service (note
+ // that not all NAVSUUGGEST suggestions come
+ // from the experimental service).
+ // For subtype definitions, please contact
+ // gcomanici@chromium.org.
SEARCH_WHAT_YOU_TYPED = 7; // The input as a search query (with the
// default engine)
SEARCH_HISTORY = 8; // A past search (with the default engine)
@@ -253,6 +261,12 @@ message OmniboxEventProto {
// Whether this item is disabled in the UI (not clickable).
optional bool is_disabled = 6;
+
+ // Used to identify the specific source / type for suggestions by the
+ // suggest server. The meaning of individual values is determined by the
+ // provider of each suggestion type and is different for every suggestion
+ // type. See enum ResultType above for more details.
+ optional int32 result_subtype_identifier = 7;
}
repeated Suggestion suggestion = 9;
« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | components/omnibox/browser/autocomplete_match.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698