Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/omnibox/browser/autocomplete_match.h

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: Add unit test for parsing and use type specifier for search suggestions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/autocomplete_match.h
diff --git a/components/omnibox/browser/autocomplete_match.h b/components/omnibox/browser/autocomplete_match.h
index 9ab496c7dc665b0f6ba3e7c7b95271b882cc1e00..8f3bee5a570c39a8d960c848cf97d26cf5f1dff7 100644
--- a/components/omnibox/browser/autocomplete_match.h
+++ b/components/omnibox/browser/autocomplete_match.h
@@ -367,6 +367,12 @@ struct AutocompleteMatch {
// Type of this match.
Type type;
+ // Used to identify the specific source / type of suggestion for suggestions
+ // provided by the suggest server. For meaning of individual values, see
+ // the server-side enum.
Mark P 2017/03/23 22:49:53 add Only used for logging.
gcomanici 2017/03/24 16:24:59 Done.
+ // The identifier 0 is reserved for cases where this specific type is unset.
+ int specific_type_identifier = 0;
Mark P 2017/03/23 22:49:53 nit: omit "=0" (chromium style I think)
gcomanici 2017/03/24 16:24:59 Done.
+
// Set with a keyword provider match if this match can show a keyword hint.
// For example, if this is a SearchProvider match for "www.amazon.com",
// |associated_keyword| could be a KeywordProvider match for "amazon.com".

Powered by Google App Engine
This is Rietveld 408576698