Add a new entry to omnibox_event.proto to log specific type of contextual suggestions

components/omnibox/browser/search_suggestion_parser.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_
 #define COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 183 matching lines @@
   class NavigationResult : public Result {
    public:
     NavigationResult(const AutocompleteSchemeClassifier& scheme_classifier,
                      const GURL& url,
                      AutocompleteMatchType::Type type,
                      const base::string16& description,
                      const std::string& deletion_url,
                      bool from_keyword_provider,
                      int relevance,
                      bool relevance_from_server,
-                     const base::string16& input_text);
+                     const base::string16& input_text,
+                     int specific_type_identifier);

[Mark P, 2017/03/21 19:54:25]

Please hoist this logic up to SuggestResult.  There's no reason it has to be
particular to URL suggestions.

[gcomanici, 2017/03/22 02:39:03]

Done.

+    NavigationResult(const NavigationResult& nav);

[Mark P, 2017/03/21 19:54:25]

Curious: why do you need to add a copy constructor.

[gcomanici, 2017/03/22 02:39:03]

I removed it. It was there because the compiler was complaining for some reason.
Now that specific_type_identifier is in Result, I don't get that compilation
warning anymore.

     ~NavigationResult() override;
 
     const GURL& url() const { return url_; }
     const base::string16& description() const { return description_; }
     const base::string16& formatted_url() const { return formatted_url_; }
+    int specific_type_identifier() const { return specific_type_identifier_; }
 
     // Fills in |match_contents_| and |match_contents_class_| to reflect how
     // the URL should be displayed and bolded against the current |input_text|.
     // If |allow_bolding_nothing| is false and |match_contents_class_| would
     // result in an entirely unbolded |match_contents_|, do nothing.
     void CalculateAndClassifyMatchContents(const bool allow_bolding_nothing,
                                            const base::string16& input_text);
 
     // Result:
     int CalculateRelevance(const AutocompleteInput& input,
                            bool keyword_provider_requested) const override;
 
    private:
     // The suggested url for navigation.
     GURL url_;
 
     // The properly formatted ("fixed up") URL string with equivalent meaning
     // to the one in |url_|.
     base::string16 formatted_url_;
 
     // The suggested navigational result description; generally the site name.
     base::string16 description_;
+
+    // Used to identify the specific source / type of suggestion for suggestions
+    // provided by the suggest server.  For meaning of individual values, see
+    // the server-side enum.
+    int specific_type_identifier_;
   };
 
   typedef std::vector<SuggestResult> SuggestResults;
   typedef std::vector<NavigationResult> NavigationResults;
 
   // A simple structure bundling most of the information (including
   // both SuggestResults and NavigationResults) returned by a call to
   // the suggest server.
   //
   // This has to be declared after the typedefs since it relies on some of them.
@@ skipping 55 matching lines @@
       const AutocompleteSchemeClassifier& scheme_classifier,
       int default_result_relevance,
       bool is_keyword_result,
       Results* results);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SearchSuggestionParser);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_