Add a new entry to omnibox_event.proto to log specific type of contextual suggestions

components/omnibox/browser/omnibox_field_trial.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/omnibox_field_trial.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/field_trial_params.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "components/metrics/proto/omnibox_event.pb.h"
 #include "components/omnibox/browser/omnibox_switches.h"
 #include "components/omnibox/browser/url_index_private_data.h"
 #include "components/search/search.h"
 #include "components/variations/active_field_trials.h"
@@ skipping 766 matching lines @@
   if (it != params.end())
     return it->second;
   // Fall back to the global instant extended context.
   it = params.find(rule + ":" + page_classification_str + ":*");
   if (it != params.end())
     return it->second;
   // Look up rule in the global context.
   it = params.find(rule + ":*:*");
   return (it != params.end()) ? it->second : std::string();
 }
+
+namespace {
+
+static const char* kContextualZeroSuggests[] = {"" /*type is not set*/,
+                                                "cooccurrence_pages",

[Mark P, 2017/03/14 20:17:49]

If we keep the human-readable names (and maybe if not), we will need to check
with the search leads to confirm that they're comfortable with revealing the
components of the suggestion system.  (This is probably okay.  They have pushed
back on specific logging--more detailed than this--in the past, so it can't hurt
to check.)

[gcomanici, 2017/03/14 20:42:55]

Can you CC somebody that can do this? Or, should I instead do this in a separate
thread? Note I could alternatively make a change on the server side to provide
numerical ids instead of these names.

[Mark P, 2017/03/14 21:04:09]

I can help do this once we have a concrete proposal for what you want to log and
where.

[gcomanici, 2017/03/15 01:35:56]

SG

+                                                "hivemind_urls",
+                                                "local_store-maps",
+                                                "local_store-webpage",
+                                                "local_store-reservation",
+                                                "movie_reviews-review",
+                                                "movie_reviews-showtimes",
+                                                "on_the_news",
+                                                "popular_domains",
+                                                "similar_pages",
+                                                "top_entity_info",
+                                                "other"};
+}
+
+// static
+std::string OmniboxFieldTrial::ContextualZeroSuggest::ToString(
+    const Type& type) {
+  static_assert(
+      arraysize(kContextualZeroSuggests) == ContextualZeroSuggest::NUM_TYPES,
+      "kContextualZeroSuggests array must have NUM_TYPES elements");
+  return kContextualZeroSuggests[type];
+}
+
+// static
+OmniboxFieldTrial::ContextualZeroSuggest::Type
+OmniboxFieldTrial::ContextualZeroSuggest::FromString(const std::string& type) {
+  if (type.empty())
+    return NOT_SET;
+  for (int i = 0; i < NUM_TYPES; ++i) {
+    if (kContextualZeroSuggests[i] == type) {
+      return (Type)i;
+    }
+  }
+  return OTHER;
+}
+
+// static
+void OmniboxFieldTrial::ContextualZeroSuggest::RecordTypeAsProvided(
+    const std::string& type_as_string) {
+  const auto type = FromString(type_as_string);
+  if (type != NOT_SET)
+    UMA_HISTOGRAM_ENUMERATION(
+        "ZeroSuggest.ContextualSuggestType.SuggestionProvided", type,
+        NUM_TYPES);
+}
+
+// static
+void OmniboxFieldTrial::ContextualZeroSuggest::RecordTypeAsUsed(
+    const std::string& type_as_string) {
+  const auto type = FromString(type_as_string);
+  if (type != NOT_SET)
+    UMA_HISTOGRAM_ENUMERATION(
+        "ZeroSuggest.ContextualSuggestType.SuggestionUsed", type, NUM_TYPES);
+}