Add a new entry to omnibox_event.proto to log specific type of contextual suggestions

components/metrics/proto/omnibox_event.proto

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Stores information about an omnibox interaction.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 option java_outer_classname = "OmniboxEventProtos";
@@ skipping 159 matching lines @@
     ON_DEVICE = 12;
     // This enum value is currently only used by Android GSA. It represents
     // a suggestion powered by a Chrome content provider.
     ON_DEVICE_CHROME = 13;
     CLIPBOARD_URL = 14;    // Suggestion coming from clipboard (iOS only).
     PHYSICAL_WEB = 15;     // Suggestions triggered by URLs broadcast by nearby
                            // devices (iOS and Android).
   }
 
   // The result set displayed on the completion popup
-  // Next tag: 7
+  // Next tag: 8
   message Suggestion {
     // Where does this result come from?
     optional ProviderType provider = 1;
 
     // What kind of result this is.
     // This corresponds to the AutocompleteMatch::Type enumeration in
     // components/omnibox/autocomplete_match.h (except for Android
     // GSA result types).
     enum ResultType {
       UNKNOWN_RESULT_TYPE = 0;    // Unknown type (should not reach here)
       URL_WHAT_YOU_TYPED = 1;     // The input as a URL
       HISTORY_URL = 2;            // A past page whose URL contains the input
       HISTORY_TITLE = 3;          // A past page whose title contains the input
       HISTORY_BODY = 4;           // DEPRECATED. A past page whose body
                                   // contains the input
       HISTORY_KEYWORD = 5;        // A past page whose keyword contains the
                                   // input
       NAVSUGGEST = 6;             // A suggested URL
+                                  //
+                                  // result_subtype_identifier is currently used
+                                  // for contextual zero suggestions provided by
+                                  // the experimental servicei (note that not all

[Mark P, 2017/03/31 20:50:25]

two separate typos in this line

[gcomanici, 2017/04/01 16:01:52]

Fixed.

+                                  // NAVSUUGGEST suggestions are contextual
+                                  // zero-suggest suggestions).

[Mark P, 2017/03/31 20:50:25]

replace:
are contextual zero-suggest suggestions
->
come from the experimental service

[gcomanici, 2017/04/01 16:01:52]

Done.

+                                  // For subtype definitions, please contact
+                                  // gcomanici@chromium.org.
       SEARCH_WHAT_YOU_TYPED = 7;  // The input as a search query (with the
                                   // default engine)
       SEARCH_HISTORY = 8;         // A past search (with the default engine)
                                   // containing the input
       SEARCH_SUGGEST = 9;         // A suggested search (with the default
                                   // engine) for a query.
       SEARCH_OTHER_ENGINE = 10;   // A search with a non-default engine
       EXTENSION_APP = 11;         // DEPRECATED. An Extension App with a
                                   // title/url that contains the input.
       CONTACT = 12;               // One of the user's contacts
@@ skipping 37 matching lines @@
     // Only set for some providers and result_types.  At the time of
     // writing this comment, it is only set for HistoryURL and
     // HistoryQuickProvider matches.
     optional int32 typed_count = 5;
 
     // Whether this item is starred (bookmarked) or not.
     optional bool is_starred = 4 [deprecated=true];
 
     // Whether this item is disabled in the UI (not clickable).
     optional bool is_disabled = 6;
+
+    // Used to identify the specific source / type for suggestions by the
+    // suggest server. The meaning of individual values is determined by the
+    // provider of each suggestion type and is different for every suggestion
+    // type. See enum ResultType above for more details.
+    optional int32 result_subtype_identifier = 7;
   }
   repeated Suggestion suggestion = 9;
 
   // A data structure that holds per-provider information, general information
   // not associated with a particular result.
   // Next tag: 6
   message ProviderInfo {
     // Which provider generated this ProviderInfo entry.
     optional ProviderType provider = 1;
 
@@ skipping 21 matching lines @@
     // The number of times this provider returned a non-zero number of
     // suggestions during this omnibox session.
     // Note that each provider may define a session differently for its
     // purposes.
     optional int32 times_returned_results_in_session = 5;
   }
   // A list of diagnostic information about each provider.  Providers
   // will appear at most once in this list.
   repeated ProviderInfo provider_info = 12;
 }