Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
index 5098a5030ba8cac8b3a66c1f7a253e238ef3bbad..3faf4d4bbf68f7af49a8a57c5f568e079c246d0e 100644
--- a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
@@ -113,7 +113,7 @@ void ScopedStyleResolver::collectFeaturesTo(
m_deviceDependentMediaQueryResults);
for (size_t i = 0; i < m_authorStyleSheets.size(); ++i) {
- ASSERT(m_authorStyleSheets[i]->ownerNode());
+ DCHECK(m_authorStyleSheets[i]->ownerNode());
StyleSheetContents* contents = m_authorStyleSheets[i]->contents();
if (contents->hasOneClient() ||
visitedSharedStyleSheetContents.insert(contents).isNewEntry)
@@ -211,7 +211,7 @@ void ScopedStyleResolver::collectMatchingAuthorRules(
ElementRuleCollector& collector,
CascadeOrder cascadeOrder) {
for (size_t i = 0; i < m_authorStyleSheets.size(); ++i) {
- ASSERT(m_authorStyleSheets[i]->ownerNode());
+ DCHECK(m_authorStyleSheets[i]->ownerNode());
MatchRequest matchRequest(&m_authorStyleSheets[i]->contents()->ruleSet(),
&m_scope->rootNode(), m_authorStyleSheets[i], i);
collector.collectMatchingRules(matchRequest, cascadeOrder);
@@ -222,7 +222,7 @@ void ScopedStyleResolver::collectMatchingShadowHostRules(
ElementRuleCollector& collector,
CascadeOrder cascadeOrder) {
for (size_t i = 0; i < m_authorStyleSheets.size(); ++i) {
- ASSERT(m_authorStyleSheets[i]->ownerNode());
+ DCHECK(m_authorStyleSheets[i]->ownerNode());
MatchRequest matchRequest(&m_authorStyleSheets[i]->contents()->ruleSet(),
&m_scope->rootNode(), m_authorStyleSheets[i], i);
collector.collectMatchingShadowHostRules(matchRequest, cascadeOrder);
@@ -245,7 +245,7 @@ void ScopedStyleResolver::collectMatchingTreeBoundaryCrossingRules(
void ScopedStyleResolver::matchPageRules(PageRuleCollector& collector) {
// Only consider the global author RuleSet for @page rules, as per the HTML5
// spec.
- ASSERT(m_scope->rootNode().isDocumentNode());
+ DCHECK(m_scope->rootNode().isDocumentNode());
for (size_t i = 0; i < m_authorStyleSheets.size(); ++i)
collector.matchPageRules(&m_authorStyleSheets[i]->contents()->ruleSet());
}

Powered by Google App Engine
This is Rietveld 408576698