Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
index 0b20b9ecb2929614521e464e83d3b84e42682940..bc8b133d333e5220857b8cdbea2483ad5384bcef 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
@@ -212,9 +212,9 @@ bool isSimpleSelectorValidAfterPseudoElement(
return false;
CSSSelector::PseudoType pseudo = simpleSelector.pseudoType();
if (pseudo == CSSSelector::PseudoNot) {
- ASSERT(simpleSelector.selectorList());
- ASSERT(simpleSelector.selectorList()->first());
- ASSERT(!simpleSelector.selectorList()->first()->tagHistory());
+ DCHECK(simpleSelector.selectorList());
+ DCHECK(simpleSelector.selectorList()->first());
+ DCHECK(!simpleSelector.selectorList()->first()->tagHistory());
pseudo = simpleSelector.selectorList()->first()->getPseudoType();
}
return isPseudoClassValidAfterPseudoElement(pseudo, compoundPseudoElement);
@@ -346,7 +346,7 @@ bool CSSSelectorParser::consumeName(CSSParserTokenRange& range,
std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeId(
CSSParserTokenRange& range) {
- ASSERT(range.peek().type() == HashToken);
+ DCHECK_EQ(range.peek().type(), HashToken);
if (range.peek().getHashTokenType() != HashTokenId)
return nullptr;
std::unique_ptr<CSSParserSelector> selector = CSSParserSelector::create();
@@ -358,8 +358,8 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeId(
std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeClass(
CSSParserTokenRange& range) {
- ASSERT(range.peek().type() == DelimiterToken);
- ASSERT(range.peek().delimiter() == '.');
+ DCHECK_EQ(range.peek().type(), DelimiterToken);
+ DCHECK_EQ(range.peek().delimiter(), '.');
range.consume();
if (range.peek().type() != IdentToken)
return nullptr;
@@ -372,7 +372,7 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeClass(
std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeAttribute(
CSSParserTokenRange& range) {
- ASSERT(range.peek().type() == LeftBracketToken);
+ DCHECK_EQ(range.peek().type(), LeftBracketToken);
CSSParserTokenRange block = range.consumeBlock();
block.consumeWhitespace();
@@ -420,7 +420,7 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeAttribute(
std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumePseudo(
CSSParserTokenRange& range) {
- ASSERT(range.peek().type() == ColonToken);
+ DCHECK_EQ(range.peek().type(), ColonToken);
range.consume();
int colons = 1;

Powered by Google App Engine
This is Rietveld 408576698