Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
diff --git a/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp b/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
index 733747635b0a3e54ff420c5e5ed98eb476f8cb7e..4ddf141ba40cfdd1ed200373c7f48ab0cf95a3cd 100644
--- a/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
+++ b/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
@@ -109,10 +109,10 @@ bool InvalidationSet::invalidatesElement(Element& element) const {
}
void InvalidationSet::combine(const InvalidationSet& other) {
- RELEASE_ASSERT(m_isAlive);
- RELEASE_ASSERT(other.m_isAlive);
- RELEASE_ASSERT(&other != this);
- RELEASE_ASSERT(type() == other.type());
+ CHECK(m_isAlive);
+ CHECK(other.m_isAlive);
+ CHECK_NE(&other, this);
+ CHECK_EQ(type(), other.type());
if (type() == InvalidateSiblings) {
SiblingInvalidationSet& siblings = toSiblingInvalidationSet(*this);
const SiblingInvalidationSet& otherSiblings =
@@ -207,28 +207,28 @@ HashSet<AtomicString>& InvalidationSet::ensureAttributeSet() {
void InvalidationSet::addClass(const AtomicString& className) {
if (wholeSubtreeInvalid())
return;
- RELEASE_ASSERT(!className.isEmpty());
+ CHECK(!className.isEmpty());
ensureClassSet().insert(className);
}
void InvalidationSet::addId(const AtomicString& id) {
if (wholeSubtreeInvalid())
return;
- RELEASE_ASSERT(!id.isEmpty());
+ CHECK(!id.isEmpty());
ensureIdSet().insert(id);
}
void InvalidationSet::addTagName(const AtomicString& tagName) {
if (wholeSubtreeInvalid())
return;
- RELEASE_ASSERT(!tagName.isEmpty());
+ CHECK(!tagName.isEmpty());
ensureTagNameSet().insert(tagName);
}
void InvalidationSet::addAttribute(const AtomicString& attribute) {
if (wholeSubtreeInvalid())
return;
- RELEASE_ASSERT(!attribute.isEmpty());
+ CHECK(!attribute.isEmpty());
ensureAttributeSet().insert(attribute);
}

Powered by Google App Engine
This is Rietveld 408576698