Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RuleFeature.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp
index 2b632e0ececfccd73997c9b1043cf23cbacabfd2..61d834977cab24996253b21581ab237dcd7e15e1 100644
--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp
+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp
@@ -250,7 +250,7 @@ InvalidationSet& ensureInvalidationSet(
void extractInvalidationSets(InvalidationSet* invalidationSet,
DescendantInvalidationSet*& descendants,
SiblingInvalidationSet*& siblings) {
- RELEASE_ASSERT(invalidationSet->isAlive());
+ CHECK(invalidationSet->isAlive());
if (invalidationSet->type() == InvalidateDescendants) {
descendants = toDescendantInvalidationSet(invalidationSet);
siblings = nullptr;
@@ -277,7 +277,7 @@ DEFINE_TRACE(RuleFeature) {
RuleFeatureSet::RuleFeatureSet() : m_isAlive(true) {}
RuleFeatureSet::~RuleFeatureSet() {
- RELEASE_ASSERT(m_isAlive);
+ CHECK(m_isAlive);
m_metadata.clear();
m_classInvalidationSets.clear();
@@ -293,14 +293,14 @@ RuleFeatureSet::~RuleFeatureSet() {
ALWAYS_INLINE InvalidationSet& RuleFeatureSet::ensureClassInvalidationSet(
const AtomicString& className,
InvalidationType type) {
- RELEASE_ASSERT(!className.isEmpty());
+ CHECK(!className.isEmpty());
return ensureInvalidationSet(m_classInvalidationSets, className, type);
}
ALWAYS_INLINE InvalidationSet& RuleFeatureSet::ensureAttributeInvalidationSet(
const AtomicString& attributeName,
InvalidationType type) {
- RELEASE_ASSERT(!attributeName.isEmpty());
+ CHECK(!attributeName.isEmpty());
return ensureInvalidationSet(m_attributeInvalidationSets, attributeName,
type);
}
@@ -308,14 +308,14 @@ ALWAYS_INLINE InvalidationSet& RuleFeatureSet::ensureAttributeInvalidationSet(
ALWAYS_INLINE InvalidationSet& RuleFeatureSet::ensureIdInvalidationSet(
const AtomicString& id,
InvalidationType type) {
- RELEASE_ASSERT(!id.isEmpty());
+ CHECK(!id.isEmpty());
return ensureInvalidationSet(m_idInvalidationSets, id, type);
}
ALWAYS_INLINE InvalidationSet& RuleFeatureSet::ensurePseudoInvalidationSet(
CSSSelector::PseudoType pseudoType,
InvalidationType type) {
- RELEASE_ASSERT(pseudoType != CSSSelector::PseudoUnknown);
+ CHECK_NE(pseudoType, CSSSelector::PseudoUnknown);
return ensureInvalidationSet(m_pseudoInvalidationSets, pseudoType, type);
}
@@ -806,7 +806,7 @@ void RuleFeatureSet::addFeaturesToInvalidationSets(
RuleFeatureSet::SelectorPreMatch RuleFeatureSet::collectFeaturesFromRuleData(
const RuleData& ruleData) {
- RELEASE_ASSERT(m_isAlive);
+ CHECK(m_isAlive);
FeatureMetadata metadata;
if (collectFeaturesFromSelector(ruleData.selector(), metadata) ==
SelectorNeverMatches)
@@ -923,9 +923,9 @@ void RuleFeatureSet::FeatureMetadata::clear() {
}
void RuleFeatureSet::add(const RuleFeatureSet& other) {
- RELEASE_ASSERT(m_isAlive);
- RELEASE_ASSERT(other.m_isAlive);
- RELEASE_ASSERT(&other != this);
+ CHECK(m_isAlive);
+ CHECK(other.m_isAlive);
+ CHECK_NE(&other, this);
for (const auto& entry : other.m_classInvalidationSets)
ensureInvalidationSet(m_classInvalidationSets, entry.key,
entry.value->type())
@@ -959,7 +959,7 @@ void RuleFeatureSet::add(const RuleFeatureSet& other) {
}
void RuleFeatureSet::clear() {
- RELEASE_ASSERT(m_isAlive);
+ CHECK(m_isAlive);
m_siblingRules.clear();
m_uncommonAttributeRules.clear();
m_metadata.clear();
« no previous file with comments | « third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp ('k') | third_party/WebKit/Source/core/css/RuleSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698