third_party/WebKit/Source/core/css/FontFaceSet.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFaceSet.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontFaceSet.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.cpp b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

index 34fab213ee13c88c5b703f7c1446c251d6f8bf2d..7f6d41e41cad03ce420b08f7007ca83853d592a2 100644

--- a/third_party/WebKit/Source/core/css/FontFaceSet.cpp

+++ b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

@@ -257,7 +257,7 @@ ScriptPromise FontFaceSet::ready(ScriptState* scriptState) {

FontFaceSet* FontFaceSet::addForBinding(ScriptState*,

FontFace* fontFace,

ExceptionState&) {

- ASSERT(fontFace);

+ DCHECK(fontFace);

if (!inActiveDocumentContext())

return this;

if (m_nonCSSConnectedFaces.contains(fontFace))

@@ -290,7 +290,7 @@ void FontFaceSet::clearForBinding(ScriptState*, ExceptionState&) {

bool FontFaceSet::deleteForBinding(ScriptState*,

FontFace* fontFace,

ExceptionState&) {

- ASSERT(fontFace);

+ DCHECK(fontFace);

if (!inActiveDocumentContext())

return false;

HeapListHashSet<Member<FontFace>>::iterator it =

@@ -310,7 +310,7 @@ bool FontFaceSet::deleteForBinding(ScriptState*,

bool FontFaceSet::hasForBinding(ScriptState*,

FontFace* fontFace,

ExceptionState&) const {

- ASSERT(fontFace);

+ DCHECK(fontFace);

if (!inActiveDocumentContext())

return false;

return m_nonCSSConnectedFaces.contains(fontFace) ||