Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
diff --git a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
index 3ed424eaf451f613ae06452c4bb016e199e99ea7..25cd232ff0fe645c55dda46cc7dc5bc1a4437433 100644
--- a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
+++ b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
@@ -69,12 +69,12 @@ const MatchResult& ElementRuleCollector::matchedResult() const {
}
StyleRuleList* ElementRuleCollector::matchedStyleRuleList() {
- ASSERT(m_mode == SelectorChecker::CollectingStyleRules);
+ DCHECK_EQ(m_mode, SelectorChecker::CollectingStyleRules);
return m_styleRuleList.release();
}
CSSRuleList* ElementRuleCollector::matchedCSSRuleList() {
- ASSERT(m_mode == SelectorChecker::CollectingCSSRules);
+ DCHECK_EQ(m_mode, SelectorChecker::CollectingCSSRules);
return m_cssRuleList.release();
}
@@ -186,13 +186,13 @@ void ElementRuleCollector::collectMatchingRules(
const MatchRequest& matchRequest,
CascadeOrder cascadeOrder,
bool matchingTreeBoundaryRules) {
- ASSERT(matchRequest.ruleSet);
- ASSERT(m_context.element());
+ DCHECK(matchRequest.ruleSet);
+ DCHECK(m_context.element());
Element& element = *m_context.element();
const AtomicString& pseudoId = element.shadowPseudoId();
if (!pseudoId.isEmpty()) {
- ASSERT(element.isStyledElement());
+ DCHECK(element.isStyledElement());
collectMatchingRulesForList(
matchRequest.ruleSet->shadowPseudoElementRules(pseudoId), cascadeOrder,
matchRequest);
@@ -285,7 +285,7 @@ void ElementRuleCollector::appendCSSOMWrapperForRule(
cssRule = findStyleRule(parentStyleSheet, rule);
else
cssRule = rule->createCSSOMWrapper();
- ASSERT(!parentStyleSheet || cssRule);
+ DCHECK(!parentStyleSheet || cssRule);
ensureRuleList()->rules().push_back(cssRule);
}
« no previous file with comments | « third_party/WebKit/Source/core/css/ElementRuleCollector.h ('k') | third_party/WebKit/Source/core/css/FontFace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698