third_party/WebKit/Source/core/css/CSSProperty.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSProperty.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSProperty.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSProperty.cpp b/third_party/WebKit/Source/core/css/CSSProperty.cpp

index df821c4ffe2b6334866e693cf65c48ca854e82b2..e48825d4cd188253ec7b17c0f2aa0e84b3a67691 100644

--- a/third_party/WebKit/Source/core/css/CSSProperty.cpp

+++ b/third_party/WebKit/Source/core/css/CSSProperty.cpp

@@ -40,8 +40,9 @@ CSSPropertyID StylePropertyMetadata::shorthandID() const {

Vector<StylePropertyShorthand, 4> shorthands;

getMatchingShorthandsForLonghand(static_cast<CSSPropertyID>(m_propertyID),

&shorthands);

- ASSERT(shorthands.size() && m_indexInShorthandsVector >= 0 &&

- m_indexInShorthandsVector < shorthands.size());

+ DCHECK(shorthands.size());

+ DCHECK_GE(m_indexInShorthandsVector, 0u);

+ DCHECK_LT(m_indexInShorthandsVector, shorthands.size());

return shorthands.at(m_indexInShorthandsVector).id();

}