third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: All windows error are Resolved now. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index de265523670001da9c92d5122c5bc6ba57531c91..d553a47001d999ea99a702183d5c2a21ac00ef87 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -345,7 +345,7 @@ bool CSSComputedStyleDeclaration::isMonospaceFont() const {

}

const ComputedStyle* CSSComputedStyleDeclaration::computeComputedStyle() const {

Node* styledNode = this->styledNode();

- ASSERT(styledNode);

+ DCHECK(styledNode);

return styledNode->ensureComputedStyle(

styledNode->isPseudoElement() ? PseudoIdNone : m_pseudoElementSpecifier);

}

@@ -499,7 +499,7 @@ String CSSComputedStyleDeclaration::getPropertyValue(

return value->cssText();

return String();

}

- ASSERT(CSSPropertyMetadata::isEnabledProperty(propertyID));

+ DCHECK(CSSPropertyMetadata::isEnabledProperty(propertyID));

return getPropertyValue(propertyID);

}